Fix initial state (#11953) Issues Resolved fixes #11946

Author: bmacombe

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue8836.cs

@@ -12,11 +12,12 @@ protected override void Init()
 			var stack = new StackLayout();
 
 			stack.Children.Add(new Label {Text = "Click the button to toggle the clear button visibility."});
+			stack.Children.Add(new Label { Text = "The default state when this page loaded is NEVER.  The clear button should not be visible until you click toggle." });
 
 			Entry = new Entry
 			{
-				Text = "Clear Button: While Editing",
-				ClearButtonVisibility = ClearButtonVisibility.WhileEditing
+				Text = "Clear Button: Never",
+				ClearButtonVisibility = ClearButtonVisibility.Never
 			};
 			stack.Children.Add(Entry);
 

Xamarin.Forms.Platform.UAP/FormsTextBox.cs

@@ -163,6 +163,7 @@ protected override void OnApplyTemplate()
 				_DeleteButtonVisibleStateGroups = stateGroups.SingleOrDefault(sg => sg.Name == "ButtonStates");
 				if (_DeleteButtonVisibleStateGroups != null)
 					_DeleteButtonVisibleState = _DeleteButtonVisibleStateGroups.States.SingleOrDefault(s => s.Name == "ButtonVisible");
+				UpdateClearButtonVisible();
 			}
 
 			_scrollViewer= GetTemplateChild("ContentElement") as ScrollViewer;
@@ -387,21 +388,26 @@ void SyncBaseText()
 			SelectionStart = base.Text.Length;
 		}
 
-		static void ClearButtonVisibleChanged(DependencyObject dependencyObject, DependencyPropertyChangedEventArgs dependencyPropertyChangedEventArgs)
+		void UpdateClearButtonVisible()
 		{
-			var textBox = (FormsTextBox)dependencyObject;
-			var visibleState = textBox._DeleteButtonVisibleState;
-			var states = textBox._DeleteButtonVisibleStateGroups?.States;
+			var visibleState = _DeleteButtonVisibleState;
+			var states = _DeleteButtonVisibleStateGroups?.States;
 
 			if (states != null && visibleState != null)
 			{
-				if (textBox.ClearButtonVisible && !states.Contains(visibleState))
+				if (ClearButtonVisible && !states.Contains(visibleState))
 					states.Add(visibleState);
 				else
 					states.Remove(visibleState);
 			}
 		}
 
+		static void ClearButtonVisibleChanged(DependencyObject dependencyObject, DependencyPropertyChangedEventArgs dependencyPropertyChangedEventArgs)
+		{
+			var textBox = (FormsTextBox)dependencyObject;
+			textBox.UpdateClearButtonVisible();
+		}
+
 		static void TextPropertyChanged(DependencyObject dependencyObject, DependencyPropertyChangedEventArgs dependencyPropertyChangedEventArgs)
 		{
 			var textBox = (FormsTextBox)dependencyObject;