PopupRenderer: check for isDisposed in OnElementPropertyChanged before taking action. Fixes #1947 (#1968)

Author: mfeingol

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/Android/PopupRenderer.android.cs

@@ -93,7 +93,7 @@ public override void Show()
 
 		protected virtual void OnElementPropertyChanged(object? sender, PropertyChangedEventArgs args)
 		{
-			if (Element is BasePopup basePopup)
+			if (Element is BasePopup basePopup && !isDisposed)
 			{
 				if (args.PropertyName == BasePopup.VerticalOptionsProperty.PropertyName
 					|| args.PropertyName == BasePopup.HorizontalOptionsProperty.PropertyName

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/UWP/PopupRenderer.uwp.cs

@@ -87,12 +87,15 @@ protected virtual void OnElementChanged(ElementChangedEventArgs<BasePopup?> e)
 
 		protected virtual void OnElementPropertyChanged(object? sender, PropertyChangedEventArgs args)
 		{
-			if (args.PropertyName == BasePopup.VerticalOptionsProperty.PropertyName ||
-				args.PropertyName == BasePopup.HorizontalOptionsProperty.PropertyName ||
-				args.PropertyName == BasePopup.SizeProperty.PropertyName ||
-				args.PropertyName == BasePopup.ColorProperty.PropertyName)
+			if (Element is BasePopup basePopup && !isDisposed)
 			{
-				ConfigureControl();
+				if (args.PropertyName == BasePopup.VerticalOptionsProperty.PropertyName ||
+					args.PropertyName == BasePopup.HorizontalOptionsProperty.PropertyName ||
+					args.PropertyName == BasePopup.SizeProperty.PropertyName ||
+					args.PropertyName == BasePopup.ColorProperty.PropertyName)
+				{
+					ConfigureControl();
+				}
 			}
 
 			ElementPropertyChanged?.Invoke(this, args);

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/iOS/PopupRenderer.ios.cs

@@ -108,18 +108,21 @@ protected virtual void OnElementChanged(ElementChangedEventArgs<BasePopup?> e)
 
 		protected virtual void OnElementPropertyChanged(object? sender, PropertyChangedEventArgs args)
 		{
-			if (args.PropertyName == BasePopup.VerticalOptionsProperty.PropertyName ||
-				args.PropertyName == BasePopup.HorizontalOptionsProperty.PropertyName)
+			if (Element is BasePopup basePopup && !isDisposed)
 			{
-				SetLayout();
-			}
-			else if (args.PropertyName == BasePopup.SizeProperty.PropertyName)
-			{
-				SetSize();
-			}
-			else if (args.PropertyName == BasePopup.ColorProperty.PropertyName)
-			{
-				SetBackgroundColor();
+				if (args.PropertyName == BasePopup.VerticalOptionsProperty.PropertyName ||
+					args.PropertyName == BasePopup.HorizontalOptionsProperty.PropertyName)
+				{
+					SetLayout();
+				}
+				else if (args.PropertyName == BasePopup.SizeProperty.PropertyName)
+				{
+					SetSize();
+				}
+				else if (args.PropertyName == BasePopup.ColorProperty.PropertyName)
+				{
+					SetBackgroundColor();
+				}
 			}
 
 			ElementPropertyChanged?.Invoke(this, args);