Skip to content

Commit 4088dfb

Browse files
authored
CA-423173: XAPI underestimates low memory emergency pool size (#6855)
The only Xen command-line related to this is `low_mem_virq_limit`, which is 64MiB. A new quicktest has shown that we are sometimes off by ~10MiB (between `Host.compute_free_memory` and actual free memory as measured by a call to Xenctrl physinfo) or more, and get failures booting VMs even after `assert_can_boot_here` said yes. Sometimes the error messages can be quite ugly, internal xenguest/xenopsd errors, instead of HOST_NOT_ENOUGH_FREE_MEMORY. After this change (together with #6854) the new quicktest doesn't fail anymore. PR to feature branch because this will need testing together with all the other NUMA changes, it may expose latent bugs elsewhere. The new testcase will get its own PR because it is quite large.
2 parents b0a269e + 4275f76 commit 4088dfb

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ocaml/squeezed/src/squeeze_xen.ml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ let ( -* ) = Int64.sub
6161
let mib = 1024L
6262

6363
(** Same as xen commandline *)
64-
let low_mem_emergency_pool = 1L ** mib
64+
(** CA-423173: this is `low_mem_virq_limit` Xen, default 64MiB *)
65+
let low_mem_emergency_pool = 64L ** mib
6566

6667
(** Return the extra amount we always add onto maxmem *)
6768
let xen_max_offset_kib domain_type =

0 commit comments

Comments
 (0)