Skip to content

Commit 93a0546

Browse files
committed
CP-423204: use new xenctrlext function HostNuma.numa_get_meminfo
in the remaining instances of the code using old numainfo.memory Signed-off-by: Marcus Granado <marcus.granado@cloud.com>
1 parent 77ac372 commit 93a0546

File tree

2 files changed

+21
-19
lines changed

2 files changed

+21
-19
lines changed

ocaml/libs/xenctrl-ext/xenctrlext.ml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,18 @@ exception Not_available
126126
let domain_claim_pages handle domid ?(numa_node = NumaNode.none) nr_pages =
127127
stub_domain_claim_pages handle domid numa_node nr_pages
128128

129+
module HostNuma = struct
130+
(* Numa state of a host *)
131+
132+
type node_meminfo = {size: int64; free: int64; claimed: int64}
133+
134+
external numa_get_meminfo : handle -> node_meminfo array
135+
= "stub_xenctrlext_numa_meminfo"
136+
end
137+
129138
let get_nr_nodes handle =
130-
let info = numainfo handle in
131-
Array.length info.memory
139+
let meminfo = HostNuma.numa_get_meminfo handle in
140+
Array.length meminfo
132141

133142
module DomainNuma = struct
134143
(* Numa state of a domain *)
@@ -167,12 +176,3 @@ module DomainNuma = struct
167176
{optimised; nodes; memory}
168177
with Failure _ -> default
169178
end
170-
171-
module HostNuma = struct
172-
(* Numa state of a host *)
173-
174-
type node_meminfo = {size: int64; free: int64; claimed: int64}
175-
176-
external numa_get_meminfo : handle -> node_meminfo array
177-
= "stub_xenctrlext_numa_meminfo"
178-
end

ocaml/xenopsd/xc/numa.ml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,17 @@ let human_readable_bytes quantity =
4949
else
5050
loop [] quantity binary_prefixes |> String.concat ", "
5151

52-
let get_memory () =
53-
let {memory; _} = numainfo xc in
54-
memory
52+
let get_memory () = HostNuma.numa_get_meminfo xc
5553

5654
let print_mem c mem =
5755
for i = 0 to Array.length mem - 1 do
58-
let {memfree; memsize} = mem.(i) in
59-
let memfree = human_readable_bytes memfree in
60-
let memsize = human_readable_bytes memsize in
56+
let {HostNuma.size; free; claimed} = mem.(i) in
57+
let memfree = human_readable_bytes free in
58+
let memsize = human_readable_bytes size in
59+
let memclaimed = human_readable_bytes claimed in
6160
Logs.app (fun m ->
62-
m "\t%d: %s free out of %s" i memfree memsize ~tags:(stamp c)
61+
m "\t%d: %s free / %s claimed out of %s" i memfree memclaimed memsize
62+
~tags:(stamp c)
6363
)
6464
done
6565

@@ -72,7 +72,9 @@ let print_diff_mem before after =
7272
let diff c old cur =
7373
let changed_yet = ref false in
7474
for i = 0 to Int.min (Array.length old) (Array.length cur) - 1 do
75-
let {memfree= a_free; _}, {memfree= b_free; _} = (old.(i), cur.(i)) in
75+
let {HostNuma.free= a_free; _}, {HostNuma.free= b_free; _} =
76+
(old.(i), cur.(i))
77+
in
7678
if a_free <> b_free then (
7779
if not !changed_yet then changed_yet := true ;
7880
let free = human_readable_bytes b_free in

0 commit comments

Comments
 (0)