Skip to content

Commit eb5b3bc

Browse files
committed
fixup! fixup! CP-308863: Count vGPU migrations
Signed-off-by: Ming Lu <[email protected]>
1 parent 5c7a313 commit eb5b3bc

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

ocaml/xapi/message_forwarding.ml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2501,10 +2501,8 @@ functor
25012501
let snapshot = Db.VM.get_record ~__context ~self:vm in
25022502
reserve_memory_for_vm ~__context ~vm ~host ~snapshot
25032503
~host_op:`vm_migrate (fun () ->
2504-
Db.VM.get_VGPUs ~__context ~self:vm
2505-
|> List.iter (fun _ ->
2506-
Xapi_stats.incr_pool_vgpu_migration_count ()
2507-
) ;
2504+
if Db.VM.get_VGPUs ~__context ~self:vm <> [] then
2505+
Xapi_stats.incr_pool_vgpu_migration_count () ;
25082506
forward_vm_op ~local_fn ~__context ~vm ~remote_fn
25092507
)
25102508
) ;
@@ -2626,10 +2624,8 @@ functor
26262624
assert_can_migrate ~__context ~vm ~dest ~live ~vdi_map
26272625
~vif_map ~vgpu_map ~options
26282626
) ;
2629-
vgpu_map
2630-
|> List.iter (fun _ ->
2631-
Xapi_stats.incr_pool_vgpu_migration_count ()
2632-
) ;
2627+
if vgpu_map <> [] then
2628+
Xapi_stats.incr_pool_vgpu_migration_count () ;
26332629
forward_migrate_send ()
26342630
)
26352631
in

ocaml/xapi/xapi_stats.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ let generate_master_stats ~__context =
5454
let vgpu_migration_count_ds =
5555
( Rrd.Host
5656
, Ds.ds_make ~name:"pool_vgpu_migration_count"
57-
~description:"Number of vGPU migrations occurred since last rrd update"
57+
~description:"Number of vGPU migrations occurred"
5858
~value:(Rrd.VT_Int64 vgpu_migration_count) ~ty:Rrd.Absolute
5959
~default:true ~min:0. ~units:"count" ()
6060
)

0 commit comments

Comments
 (0)