Bugfix

Author: dcherian

cf_xarray/coding.py

@@ -105,7 +105,7 @@ def decode_compress_to_multi_index(encoded, idxnames=None):
 
         names = encoded[idxname].attrs["compress"].split(" ")
         shape = [encoded.sizes[dim] for dim in names]
-        indices = np.unravel_index(encoded.landpoint.data, shape)
+        indices = np.unravel_index(encoded[idxname].data, shape)
         arrays = [encoded[dim].data[index] for dim, index in zip(names, indices)]
         mindex = pd.MultiIndex.from_arrays(arrays, names=names)
 

cf_xarray/tests/test_coding.py

@@ -18,13 +18,14 @@
         ),
     ],
 )
-@pytest.mark.parametrize("idxnames", ["landpoint", ("landpoint",), None])
+@pytest.mark.parametrize("idxnames", ["foo", "landpoint", ("landpoint",), None])
 def test_compression_by_gathering_multi_index_roundtrip(mindex, idxnames):
+    dim = "foo" if idxnames == "foo" else "landpoint"
     dataset = xr.Dataset(
-        data_vars={"landsoilt": ("landpoint", np.random.randn(4), {"foo": "bar"})},
+        data_vars={"landsoilt": (dim, np.random.randn(4), {"foo": "bar"})},
         coords={
-            "landpoint": ("landpoint", mindex, {"long_name": "land point number"}),
-            "coord1": ("landpoint", [1, 2, 3, 4], {"foo": "baz"}),
+            dim: (dim, mindex, {"long_name": "land point number"}),
+            "coord1": (dim, [1, 2, 3, 4], {"foo": "baz"}),
         },
         attrs={"dataset": "test dataset"},
     )
@@ -33,9 +34,9 @@ def test_compression_by_gathering_multi_index_roundtrip(mindex, idxnames):
 
     encoded = cfxr.encode_multi_index_as_compress(dataset, idxnames)
     roundtrip = cfxr.decode_compress_to_multi_index(encoded, idxnames)
-    assert "compress" not in roundtrip["landpoint"].encoding
+    assert "compress" not in roundtrip[dim].encoding
     xr.testing.assert_identical(roundtrip, dataset)
 
-    dataset["landpoint"].attrs["compress"] = "lat lon"
+    dataset[dim].attrs["compress"] = "lat lon"
     with pytest.raises(ValueError):
         cfxr.encode_multi_index_as_compress(dataset, idxnames)