Apply suggestions from code review

Co-authored-by: Mathias Hauser <[email protected]>

Author: keewis

.github/workflows/ci.yml

@@ -80,7 +80,7 @@ jobs:
               echo "workflow passed"
               export STATUS=0
           elif [[ "${{ steps.action-run.outcome }}" == "failure" && ${{ matrix.expected-failure }} == "true" ]]; then
-              # normal pass
+              # expected failure
               echo "workflow xfailed"
               export STATUS=0
           else

minimum_versions.py

@@ -107,8 +107,8 @@ def parse_environment(text):
     for dep in env["dependencies"]:
         spec, warnings_ = Spec.parse(dep)
 
-        warnings.append(warnings_)
         specs.append(spec)
+        warnings.append(warnings_)
 
     return specs, warnings