Merge branch 'main' into cubed_xarray_tests

Author: keewis

xarray_array_testing/reduction.py

@@ -1,6 +1,7 @@
 from contextlib import nullcontext
 
 import hypothesis.strategies as st
+import pytest
 import xarray.testing.strategies as xrst
 from hypothesis import HealthCheck, given, note, settings
 
@@ -14,27 +15,18 @@ def expected_errors(op, **parameters):
 
     # TODO understand the differing executors health check error
     @settings(suppress_health_check=[HealthCheck.differing_executors])
+    @pytest.mark.parametrize("op", ["mean", "sum", "prod", "std", "var"])
     @given(st.data())
-    def test_variable_mean(self, data):
+    def test_variable_numerical_reduce(self, op, data):
         variable = data.draw(xrst.variables(array_strategy_fn=self.array_strategy_fn))
 
         note(f"note: {variable}")
 
         with self.expected_errors("mean", variable=variable):
-            actual = variable.mean().data
-            expected = self.xp.mean(variable.data)
-
-            assert isinstance(actual, self.array_type), type(actual)
-            self.assert_equal(actual, expected)
-
-    @settings(suppress_health_check=[HealthCheck.differing_executors])
-    @given(st.data())
-    def test_variable_prod(self, data):
-        variable = data.draw(xrst.variables(array_strategy_fn=self.array_strategy_fn))
-
-        with self.expected_errors("prod", variable=variable):
-            actual = variable.prod().data
-            expected = self.xp.prod(variable.data)
+            # compute using xr.Variable.<OP>()
+            actual = getattr(variable, op)().data
+            # compute using xp.<OP>(array)
+            expected = getattr(self.xp, op)(variable.data)
 
             assert isinstance(actual, self.array_type), type(actual)
             self.assert_equal(actual, expected)