Merge pull request #117 from astropenguin/astropenguin/issue116

Assign dim coords to DataArray first

Author: astropenguin

xarray_dataclasses/dataarray.py

@@ -116,7 +116,12 @@ def asdataarray(
     dataarray = dataoptions.factory(model.data[0](reference))
 
     for coord in model.coord:
-        dataarray.coords.update({coord.name: coord(dataarray)})
+        if coord.name in dataarray.dims:
+            dataarray.coords.update({coord.name: coord(dataarray)})
+
+    for coord in model.coord:
+        if coord.name not in dataarray.dims:
+            dataarray.coords.update({coord.name: coord(dataarray)})
 
     for attr in model.attr:
         dataarray.attrs.update({attr.name: attr()})

xarray_dataclasses/dataset.py

@@ -119,7 +119,12 @@ def asdataset(
         dataset.update({data.name: data(reference)})
 
     for coord in model.coord:
-        dataset.coords.update({coord.name: coord(dataset)})
+        if coord.name in dataset.dims:
+            dataset.coords.update({coord.name: coord(dataset)})
+
+    for coord in model.coord:
+        if coord.name not in dataset.dims:
+            dataset.coords.update({coord.name: coord(dataset)})
 
     for attr in model.attr:
         dataset.attrs.update({attr.name: attr()})