Skip to content

Commit 9f6f8bf

Browse files
committed
Fix F402
1 parent 4b17aa3 commit 9f6f8bf

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/xarray_dataclasses/datamodel.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,12 @@ def from_dataclass(cls, dataclass: AnyDataClass[PInit]) -> "DataModel":
187187
model = cls()
188188
eval_dataclass(dataclass)
189189

190-
for field in dataclass.__dataclass_fields__.values():
191-
value = getattr(dataclass, field.name, MISSING)
192-
entry = get_entry(field, value)
190+
for field_value in dataclass.__dataclass_fields__.values():
191+
value = getattr(dataclass, field_value.name, MISSING)
192+
entry = get_entry(field_value, value)
193193

194194
if entry is not None:
195-
model.entries[field.name] = entry
195+
model.entries[field_value.name] = entry
196196

197197
return model
198198

@@ -203,10 +203,10 @@ def eval_dataclass(dataclass: AnyDataClass[PInit]) -> None:
203203
if not is_dataclass(dataclass):
204204
raise TypeError("Not a dataclass or its object.")
205205

206-
fields = dataclass.__dataclass_fields__.values()
206+
field_values = dataclass.__dataclass_fields__.values()
207207

208208
# do nothing if field types are already evaluated
209-
if not any(isinstance(field.type, str) for field in fields):
209+
if not any(isinstance(field_value.type, str) for field_value in field_values):
210210
return
211211

212212
# otherwise, replace field types with evaluated types
@@ -215,8 +215,8 @@ def eval_dataclass(dataclass: AnyDataClass[PInit]) -> None:
215215

216216
types = get_type_hints(dataclass, include_extras=True)
217217

218-
for field in fields:
219-
field.type = types[field.name]
218+
for field_value in field_values:
219+
field_value.type = types[field_value.name]
220220

221221

222222
def get_entry(field: AnyField, value: Any) -> Optional[AnyEntry]:

0 commit comments

Comments
 (0)