#153 Merge pull request from astropenguin/astropenguin/issue152

Update static type check

Author: astropenguin

.devcontainer/devcontainer.json

@@ -15,7 +15,6 @@
     "settings": {
         "files.insertFinalNewline": true,
         "files.trimTrailingWhitespace": true,
-        "python.analysis.typeCheckingMode": "strict",
         "python.formatting.provider": "black",
         "python.languageServer": "Pylance",
         "[python]": {

.github/workflows/tests.yml

@@ -15,22 +15,20 @@ jobs:
     env:
       POETRY_VIRTUALENVS_CREATE: false
     strategy:
+      fail-fast: false
       matrix:
         python: ["3.7", "3.8", "3.9", "3.10"]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-python@v2
         with:
           python-version: ${{ matrix.python }}
-      - uses: actions/setup-node@v2
-        with:
-          node-version: "lts/gallium"
       - name: Install project dependencies
-        run: pip install poetry && poetry install && npm install
+        run: pip install poetry && poetry install
       - name: Test code's formatting (Black)
         run: black --check docs tests xarray_dataclasses
       - name: Test code's typing (Pyright)
-        run: npx pyright docs tests xarray_dataclasses
+        run: pyright docs tests xarray_dataclasses
       - name: Test code's execution (pytest)
         run: pytest -v tests
       - name: Test docs' building (Sphinx)

package-lock.json

@@ -13,7 +13,10 @@ documentation = "https://astropenguin.github.io/xarray-dataclasses/"
 python = ">=3.7.1, <3.11"
 morecopy = "^0.2"
 more-itertools = "^8.12"
-numpy = "^1.15"
+numpy = [
+    { version = ">=1.15, <1.22", python = ">=3.7.1, <3.8" },
+    { version = "^1.15", python = ">=3.8, <3.11" },
+]
 typing-extensions = "^3.10"
 xarray = [
     { version = ">=0.18, <0.21", python = ">=3.7.1, <3.8" },
@@ -28,9 +31,17 @@ ipython = [
 ]
 myst-parser = "^0.17"
 pydata-sphinx-theme = "^0.8"
+pyright = "^1.1"
 pytest = "^7.1"
 sphinx = "^4.5"
 
+[tool.pyright]
+reportImportCycles = "warning"
+reportUnknownArgumentType = "warning"
+reportUnknownMemberType = "warning"
+reportUnknownVariableType = "warning"
+typeCheckingMode = "strict"
+
 [build-system]
 requires = ["poetry-core>=1.0.0"]
 build-backend = "poetry.core.masonry.api"

package.json

@@ -2,18 +2,6 @@
 __version__ = "1.1.0"
 
 
-# for Python 3.7 and 3.8
-def _make_field_generic():
-    from dataclasses import Field
-    from typing import Sequence
-
-    GenericAlias = type(Sequence[int])
-    Field.__class_getitem__ = classmethod(GenericAlias)
-
-
-_make_field_generic()
-
-
 # submodules
 from . import dataarray
 from . import dataset

poetry.lock

@@ -27,7 +27,7 @@
 # submodules
 from .datamodel import DataModel
 from .dataoptions import DataOptions
-from .typing import DataClass, DataClassFields, DataType, Order, Shape, Sizes
+from .typing import AnyArray, DataClass, DataClassFields, DataType, Order, Shape, Sizes
 
 
 # type hints
@@ -168,7 +168,7 @@ def new(cls: Any, *args: Any, **kwargs: Any) -> Any:
     @classmethod
     def shaped(
         cls: Type[OptionedClass[PInit, TDataArray]],
-        func: Callable[[Shape], np.ndarray],
+        func: Callable[[Shape], AnyArray],
         shape: Union[Shape, Sizes],
         **kwargs: Any,
     ) -> TDataArray:
@@ -178,7 +178,7 @@ def shaped(
     @classmethod
     def shaped(
         cls: Type[DataClass[PInit]],
-        func: Callable[[Shape], np.ndarray],
+        func: Callable[[Shape], AnyArray],
         shape: Union[Shape, Sizes],
         **kwargs: Any,
     ) -> xr.DataArray:
@@ -187,7 +187,7 @@ def shaped(
     @classmethod
     def shaped(
         cls: Any,
-        func: Callable[[Shape], np.ndarray],
+        func: Callable[[Shape], AnyArray],
         shape: Union[Shape, Sizes],
         **kwargs: Any,
     ) -> Any:

pyproject.toml

@@ -3,7 +3,7 @@
 
 
 # standard library
-from dataclasses import Field, dataclass, field, is_dataclass
+from dataclasses import dataclass, field, is_dataclass
 from typing import Any, Dict, Hashable, List, Optional, Tuple, Type, Union, cast
 
 
@@ -15,6 +15,7 @@
 
 # submodules
 from .typing import (
+    AnyField,
     DataClass,
     DataType,
     Dims,
@@ -204,7 +205,7 @@ def eval_dataclass(dataclass: AnyDataClass[PInit]) -> None:
         field.type = types[field.name]
 
 
-def get_entry(field: Field[Any], value: Any) -> AnyEntry:
+def get_entry(field: AnyField, value: Any) -> AnyEntry:
     """Create an entry from a field and its value."""
     field_type = get_field_type(field.type)
     repr_type = get_repr_type(field.type)