Skip to content

Commit 94780e6

Browse files
committed
Add test, restore coord attrs for the most_common method
1 parent bf75cc7 commit 94780e6

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/xarray_regrid/methods/most_common.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,8 @@ def most_common(data: xr.Dataset, target_ds: xr.Dataset, time_dim: str) -> xr.Da
151151
"""
152152
dim_order = data.dims
153153
coords = utils.common_coords(data, target_ds, remove_coord=time_dim)
154+
coord_attrs = {coord: data[coord].attrs for coord in target_ds.coords}
155+
154156
bounds = tuple(
155157
_construct_intervals(target_ds[coord].to_numpy()) for coord in coords
156158
)
@@ -185,6 +187,7 @@ def most_common(data: xr.Dataset, target_ds: xr.Dataset, time_dim: str) -> xr.Da
185187
ds_regrid = ds_regrid.rename({f"{coord}_bins": coord for coord in coords})
186188
for coord in coords:
187189
ds_regrid[coord] = target_ds[coord]
190+
ds_regrid[coord].attrs = coord_attrs[coord]
188191

189192
return ds_regrid.transpose(*dim_order)
190193

tests/test_most_common.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ def test_attrs_dataarray(dummy_lc_data, dummy_target_grid):
8585
da_regrid = dummy_lc_data["lc"].regrid.most_common(dummy_target_grid)
8686
assert da_regrid.attrs != {}
8787
assert da_regrid.attrs == dummy_lc_data["lc"].attrs
88+
assert da_regrid["longitude"].attrs == dummy_lc_data["longitude"].attrs
8889

8990

9091
def test_attrs_dataset(dummy_lc_data, dummy_target_grid):
@@ -93,3 +94,4 @@ def test_attrs_dataset(dummy_lc_data, dummy_target_grid):
9394
)
9495
assert ds_regrid.attrs != {}
9596
assert ds_regrid.attrs == dummy_lc_data.attrs
97+
assert ds_regrid["longitude"].attrs == dummy_lc_data["longitude"].attrs

0 commit comments

Comments
 (0)