handle large last chunk

Author: Joseph Hamman

README.md

@@ -49,8 +49,7 @@ schema_ds.validate(da.to_dataset())
 
 This is a very early prototype of a library. Some key things are missing:
 
-1. Validation of `coords` and `attrs`. None of these are implemented yet.
-1. Class-based schema's for parts of the Xarray data model. Most validations are currently made as direct comparisons (`da.name == self.name`) but a more robust approach is possible that leverages classes for each component of the data model. We're already handling some special cases using `None` as a sentinel value to allow for wildcard-like behavior in places (i.e. `dims` and `shape`)
+1. Validation of `coords` and `attrs`. These are implemented yet.
 1. Exceptions: Pandera accumulates schema exceptions and reports them all at once. Currently, we are a eagerly raising `SchemaErrors` when the are found.
 
 ## license

tests/test_core.py

@@ -87,6 +87,7 @@ def test_component_schema(component, schema_args, validate, json):
         ),
         (ChunksSchema, {'x': -1}, (((1, 2, 1),), ('x',), (4,)), r'.*did not match.*'),
         (ChunksSchema, {'x': 2}, (((2, 3, 2),), ('x',), (7,)), r'.*did not match.*'),
+        (ChunksSchema, {'x': 2}, (((2, 2, 3),), ('x',), (7,)), r'.*did not match.*'),
         (ChunksSchema, {'x': 2, 'y': -1}, (((2, 2), (5, 5)), ('x', 'y'), (4, 10)), r'.*(5).*'),
     ],
 )

xarray_schema/components.py

@@ -156,7 +156,7 @@ def validate(
                     if ec < 0:
                         ec = dim_sizes[key]
                     ac = dim_chunks[key]
-                    if not all(a == ec for a in ac[:-1]) and ac[-1] <= ec:
+                    if not all(a == ec for a in ac[:-1]) or ac[-1] <= ec:
                         raise SchemaError(f'{key} chunks did not match: {ac} != {ec}')
 
                 else:  # assumes ec is an iterable