fix(ui): race condition in ImageDetailsCheck tests (podman-desktop#12077)

* fix(ui): race condition in test

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>

* fix: better handling of workflow

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>

---------

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>

Author: axel7083

packages/renderer/src/lib/image/ImageDetailsCheck.spec.ts

@@ -35,7 +35,7 @@ beforeAll(() => {
   Object.defineProperty(window, 'getCancellableTokenSource', { value: getCancellableTokenSourceMock });
   getCancellableTokenSourceMock.mockImplementation(() => tokenID);
   Object.defineProperty(window, 'imageCheck', { value: imageCheckMock });
-  Object.defineProperty(window, 'cancelToken', { value: cancelTokenSpy });
+  Object.defineProperty(window, 'cancelToken', { value: cancelTokenSpy.mockResolvedValue(undefined) });
   Object.defineProperty(window, 'telemetryTrack', { value: vi.fn().mockResolvedValue(undefined) });
 });
 

packages/renderer/src/lib/image/ImageDetailsCheck.svelte

@@ -27,6 +27,7 @@ let cancellableTokenId: number = $state(0);
 
 let remainingProviders: number = $state(0);
 let aborted = $state(false);
+let aborting = $state(false);
 
 let providersUnsubscribe: Unsubscriber;
 
@@ -115,17 +116,28 @@ async function callProviders(_providers: readonly ImageCheckerInfo[]): Promise<v
 }
 
 async function handleAbort(): Promise<void> {
+  // avoid race condition
+  if (aborting) return;
+
   if (cancellableTokenId !== 0 && remainingProviders > 0) {
-    await window.cancelToken(cancellableTokenId);
+    aborting = true;
+    await window.cancelToken(cancellableTokenId).finally(() => {
+      aborting = false;
+    });
+    // reset token
+    cancellableTokenId = 0;
+    aborted = true;
+
+    // update providers
     providers = providers.map(p => {
       if (p.state === 'running') {
         p.state = 'canceled';
       }
       return p;
     });
-    aborted = true;
+
+    // telemetry
     await window.telemetryTrack('imageCheck.aborted');
-    cancellableTokenId = 0;
   }
 }
 </script>