Haptic feedback via UIImpactFeedbackGenerator

Avoids code duplication by introducing a helper method, which is placed in Utilities for future purpose (providing haptic feedback from other controllers as well). The generator is made static and only created once to avoid feedback delays. The feedback is now a medium haptic one-time impact which comes right with touching the remote buttons.

Author: wutschel

XBMC Remote/RemoteController.m

@@ -586,13 +586,7 @@ - (IBAction)holdKey:(id)sender {
                                                        selector:@selector(longpressKey:)
                                                        userInfo:params
                                                         repeats:NO];
-    
-    NSUserDefaults *userDefaults = [NSUserDefaults standardUserDefaults];
-    BOOL startVibrate = [userDefaults boolForKey:@"vibrate_preference"];
-    if (startVibrate) {
-        [[UIDevice currentDevice] playInputClick];
-        AudioServicesPlaySystemSound(kSystemSoundID_Vibrate);
-    }
+    [Utilities giveHapticFeedback];
 }
 
 - (IBAction)stopHoldKey:(id)sender {
@@ -839,13 +833,7 @@ - (void)processButtonPress:(NSInteger)buttonTag {
 
 - (IBAction)startVibrate:(id)sender {
     [self processButtonPress:[sender tag]];
-    
-    NSUserDefaults *userDefaults = [NSUserDefaults standardUserDefaults];
-    BOOL startVibrate = [userDefaults boolForKey:@"vibrate_preference"];
-    if (startVibrate) {
-        [[UIDevice currentDevice] playInputClick];
-        AudioServicesPlaySystemSound(kSystemSoundID_Vibrate);
-    }
+    [Utilities giveHapticFeedback];
     [[NSNotificationCenter defaultCenter] postNotificationName:@"Input.OnInputFinished" object:nil userInfo:nil];
 }
 
@@ -929,6 +917,7 @@ - (void)processButtonLongPress:(NSInteger)buttonTag {
 - (IBAction)handleButtonLongPress:(UILongPressGestureRecognizer*)gestureRecognizer {
     if (gestureRecognizer.state == UIGestureRecognizerStateBegan) {
         [self processButtonLongPress:gestureRecognizer.view.tag];
+        [Utilities giveHapticFeedback];
     }
 }
 

XBMC Remote/Utilities.h

@@ -91,6 +91,7 @@ typedef NS_ENUM(NSInteger, LogoBackgroundType) {
 + (CGFloat)getTopPadding;
 + (CGFloat)getTopPaddingWithNavBar:(UINavigationController*)navCtrl;
 + (void)sendXbmcHttp:(NSString*)command;
++ (void)giveHapticFeedback;
 + (NSString*)getAppVersionString;
 + (void)checkForReviewRequest;
 + (void)checkLocalNetworkAccess;

XBMC Remote/Utilities.m

@@ -975,6 +975,18 @@ + (void)sendXbmcHttp:(NSString*)command {
     [[NSURLSession.sharedSession dataTaskWithURL:[NSURL URLWithString:serverHTTP]] resume];
 }
 
++ (void)giveHapticFeedback {
+    NSUserDefaults *userDefaults = [NSUserDefaults standardUserDefaults];
+    BOOL feedbackEnabled = [userDefaults boolForKey:@"vibrate_preference"];
+    if (feedbackEnabled) {
+        static UIImpactFeedbackGenerator *generator;
+        if (!generator) {
+            generator = [[UIImpactFeedbackGenerator alloc] initWithStyle:UIImpactFeedbackStyleMedium];
+        }
+        [generator impactOccurred];
+    }
+}
+
 + (NSString*)getAppVersionString {
     NSDictionary *infoDict = NSBundle.mainBundle.infoDictionary;
     NSString *appVersion = [NSString stringWithFormat:@"v%@ (%@)", infoDict[@"CFBundleShortVersionString"], infoDict[(NSString*)kCFBundleVersionKey]];