Skip to content

Commit 39df9c0

Browse files
wutschelwutschel
committed
Directly call playerAction:params:
1 parent 86a6951 commit 39df9c0

File tree

2 files changed

+28
-36
lines changed

2 files changed

+28
-36
lines changed

‎XBMC Remote/NowPlaying.m‎

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,10 +1110,6 @@ - (void)clearPlaylist:(int)playlistID {
11101110
}];
11111111
}
11121112

1113-
- (void)playbackAction:(NSString*)action params:(NSDictionary*)parameters {
1114-
[self playerAction:action params:parameters playerid:currentPlayerID];
1115-
}
1116-
11171113
- (void)updatePartyModePlaylist {
11181114
lastSelected = SELECTED_NONE;
11191115
storeSelection = nil;
@@ -1533,39 +1529,39 @@ - (IBAction)startVibrate:(id)sender {
15331529
if (AppDelegate.instance.serverVersion > 11) {
15341530
action = @"Player.GoTo";
15351531
params = @{@"to": @"previous"};
1536-
[self playbackAction:action params:params];
1532+
[self playerAction:action params:params];
15371533
}
15381534
else {
15391535
action = @"Player.GoPrevious";
15401536
params = nil;
1541-
[self playbackAction:action params:nil];
1537+
[self playerAction:action params:nil];
15421538
}
15431539
ProgressSlider.value = 0;
15441540
break;
15451541

15461542
case TAG_ID_PLAYPAUSE:
15471543
action = @"Player.PlayPause";
15481544
params = nil;
1549-
[self playbackAction:action params:nil];
1545+
[self playerAction:action params:nil];
15501546
break;
15511547

15521548
case TAG_ID_STOP:
15531549
action = @"Player.Stop";
15541550
params = nil;
1555-
[self playbackAction:action params:nil];
1551+
[self playerAction:action params:nil];
15561552
storeSelection = nil;
15571553
break;
15581554

15591555
case TAG_ID_NEXT:
15601556
if (AppDelegate.instance.serverVersion > 11) {
15611557
action = @"Player.GoTo";
15621558
params = @{@"to": @"next"};
1563-
[self playbackAction:action params:params];
1559+
[self playerAction:action params:params];
15641560
}
15651561
else {
15661562
action = @"Player.GoNext";
15671563
params = nil;
1568-
[self playbackAction:action params:nil];
1564+
[self playerAction:action params:nil];
15691565
}
15701566
break;
15711567

@@ -1581,13 +1577,13 @@ - (IBAction)startVibrate:(id)sender {
15811577
case TAG_SEEK_BACKWARD:
15821578
action = @"Player.Seek";
15831579
params = [Utilities buildPlayerSeekStepParams:@"smallbackward"];
1584-
[self playbackAction:action params:params];
1580+
[self playerAction:action params:params];
15851581
break;
15861582

15871583
case TAG_SEEK_FORWARD:
15881584
action = @"Player.Seek";
15891585
params = [Utilities buildPlayerSeekStepParams:@"smallforward"];
1590-
[self playbackAction:action params:params];
1586+
[self playerAction:action params:params];
15911587
break;
15921588

15931589
default:
@@ -1672,10 +1668,10 @@ - (IBAction)changeRepeat:(id)sender {
16721668

16731669
// Send the command to Kodi
16741670
if (AppDelegate.instance.serverVersion > 11) {
1675-
[self playbackAction:@"Player.SetRepeat" params:@{@"playerid": @(currentPlayerID), @"repeat": @"cycle"}];
1671+
[self playerAction:@"Player.SetRepeat" params:@{@"playerid": @(currentPlayerID), @"repeat": @"cycle"}];
16761672
}
16771673
else {
1678-
[self playbackAction:@"Player.Repeat" params:@{@"playerid": @(currentPlayerID), @"state": newRepeatStatus}];
1674+
[self playerAction:@"Player.Repeat" params:@{@"playerid": @(currentPlayerID), @"state": newRepeatStatus}];
16791675
}
16801676

16811677
// Update the button status
@@ -1825,11 +1821,11 @@ - (IBAction)handleButtonLongPress:(UILongPressGestureRecognizer*)gestureRecogniz
18251821
if (gestureRecognizer.state == UIGestureRecognizerStateBegan) {
18261822
switch (gestureRecognizer.view.tag) {
18271823
case TAG_SEEK_BACKWARD:// BACKWARD BUTTON - DECREASE PLAYBACK SPEED
1828-
[self playbackAction:@"Player.SetSpeed" params:@{@"speed": @"decrement"}];
1824+
[self playerAction:@"Player.SetSpeed" params:@{@"speed": @"decrement"}];
18291825
break;
18301826

18311827
case TAG_SEEK_FORWARD:// FORWARD BUTTON - INCREASE PLAYBACK SPEED
1832-
[self playbackAction:@"Player.SetSpeed" params:@{@"speed": @"increment"}];
1828+
[self playerAction:@"Player.SetSpeed" params:@{@"speed": @"increment"}];
18331829
break;
18341830

18351831
case TAG_ID_EDIT:// EDIT TABLE

‎XBMC Remote/RemoteController.m‎

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -460,10 +460,6 @@ - (void)audioStreamActionSheet {
460460
}];
461461
}
462462

463-
- (void)playbackAction:(NSString*)action params:(NSDictionary*)parameters {
464-
[self playerAction:action params:parameters];
465-
}
466-
467463
- (void)simpleAction:(NSString*)action params:(NSDictionary*)params xbmcHttp:(NSString*)command {
468464
[self simpleAction:action params:params completion:^(NSString *methodName, NSInteger callId, id methodResult, DSJSONRPCError *methodError, NSError *error) {
469465
// Backwards compatibility for Kodi "Eden" which supports xbmchttp but not JSON API for some commands
@@ -497,7 +493,7 @@ - (void)showActionAudiostreams:(NSArray*)sheetActions {
497493
if (![audiostreamsDictionary[@"audiostreams"][i] isEqual:audiostreamsDictionary[@"currentaudiostream"]]) {
498494
id audiostreamIndex = audiostreamsDictionary[@"audiostreams"][i][@"index"];
499495
if (audiostreamIndex) {
500-
[self playbackAction:@"Player.SetAudioStream" params:@{@"stream": audiostreamIndex}];
496+
[self playerAction:@"Player.SetAudioStream" params:@{@"stream": audiostreamIndex}];
501497
[self showSubInfo:actiontitle color:SUCCESS_MESSAGE_COLOR];
502498
}
503499
}
@@ -527,7 +523,7 @@ - (void)showActionSubtitles:(NSArray*)sheetActions {
527523

528524
UIAlertAction *action_disable = [UIAlertAction actionWithTitle:LOCALIZED_STR(@"Disable subtitles") style:UIAlertActionStyleDestructive handler:^(UIAlertAction *action) {
529525
[self showSubInfo:LOCALIZED_STR(@"Subtitles disabled") color:SUCCESS_MESSAGE_COLOR];
530-
[self playbackAction:@"Player.SetSubtitle" params:@{@"subtitle": @"off"}];
526+
[self playerAction:@"Player.SetSubtitle" params:@{@"subtitle": @"off"}];
531527
}];
532528
if ([subsDictionary[@"subtitleenabled"] boolValue]) {
533529
[alertCtrl addAction:action_disable];
@@ -542,8 +538,8 @@ - (void)showActionSubtitles:(NSArray*)sheetActions {
542538
![subsDictionary[@"subtitleenabled"] boolValue]) {
543539
id subsIndex = subsDictionary[@"subtitles"][i][@"index"];
544540
if (subsIndex) {
545-
[self playbackAction:@"Player.SetSubtitle" params:@{@"subtitle": subsIndex}];
546-
[self playbackAction:@"Player.SetSubtitle" params:@{@"subtitle": @"on"}];
541+
[self playerAction:@"Player.SetSubtitle" params:@{@"subtitle": subsIndex}];
542+
[self playerAction:@"Player.SetSubtitle" params:@{@"subtitle": @"on"}];
547543
[self showSubInfo:actiontitle color:SUCCESS_MESSAGE_COLOR];
548544
}
549545
}
@@ -709,62 +705,62 @@ - (void)processButtonPress:(NSInteger)buttonTag {
709705
case TAG_BUTTON_SEEK_BACKWARD:
710706
action = @"Player.Seek";
711707
params = [Utilities buildPlayerSeekStepParams:@"smallbackward"];
712-
[self playbackAction:action params:params];
708+
[self playerAction:action params:params];
713709
break;
714710

715711
case TAG_BUTTON_SEEK_BACKWARD_BIG:
716712
action = @"Player.Seek";
717713
params = [Utilities buildPlayerSeekStepParams:@"bigbackward"];
718-
[self playbackAction:action params:params];
714+
[self playerAction:action params:params];
719715
break;
720716

721717
case TAG_BUTTON_PLAY_PAUSE:
722718
action = @"Player.PlayPause";
723719
params = nil;
724-
[self playbackAction:action params:nil];
720+
[self playerAction:action params:nil];
725721
break;
726722

727723
case TAG_BUTTON_SEEK_FORWARD:
728724
action = @"Player.Seek";
729725
params = [Utilities buildPlayerSeekStepParams:@"smallforward"];
730-
[self playbackAction:action params:params];
726+
[self playerAction:action params:params];
731727
break;
732728

733729
case TAG_BUTTON_SEEK_FORWARD_BIG:
734730
action = @"Player.Seek";
735731
params = [Utilities buildPlayerSeekStepParams:@"bigforward"];
736-
[self playbackAction:action params:params];
732+
[self playerAction:action params:params];
737733
break;
738734

739735
case TAG_BUTTON_PREVIOUS:
740736
if (AppDelegate.instance.serverVersion > 11) {
741737
action = @"Player.GoTo";
742738
params = @{@"to": @"previous"};
743-
[self playbackAction:action params:params];
739+
[self playerAction:action params:params];
744740
}
745741
else {
746742
action = @"Player.GoPrevious";
747743
params = nil;
748-
[self playbackAction:action params:nil];
744+
[self playerAction:action params:nil];
749745
}
750746
break;
751747

752748
case TAG_BUTTON_STOP:
753749
action = @"Player.Stop";
754750
params = nil;
755-
[self playbackAction:action params:nil];
751+
[self playerAction:action params:nil];
756752
break;
757753

758754
case TAG_BUTTON_NEXT:
759755
if (AppDelegate.instance.serverVersion > 11) {
760756
action = @"Player.GoTo";
761757
params = @{@"to": @"next"};
762-
[self playbackAction:action params:params];
758+
[self playerAction:action params:params];
763759
}
764760
else {
765761
action = @"Player.GoNext";
766762
params = nil;
767-
[self playbackAction:action params:nil];
763+
[self playerAction:action params:nil];
768764
}
769765
break;
770766

@@ -859,11 +855,11 @@ - (void)processButtonLongPress:(NSInteger)buttonTag {
859855
break;
860856

861857
case TAG_BUTTON_SEEK_BACKWARD: // DECREASE PLAYBACK SPEED
862-
[self playbackAction:@"Player.SetSpeed" params:@{@"speed": @"decrement"}];
858+
[self playerAction:@"Player.SetSpeed" params:@{@"speed": @"decrement"}];
863859
break;
864860

865861
case TAG_BUTTON_SEEK_FORWARD: // INCREASE PLAYBACK SPEED
866-
[self playbackAction:@"Player.SetSpeed" params:@{@"speed": @"increment"}];
862+
[self playerAction:@"Player.SetSpeed" params:@{@"speed": @"increment"}];
867863
break;
868864

869865
case TAG_BUTTON_INFO: // CODEC INFO

0 commit comments

Comments
 (0)