Skip to content

Commit 517b420

Browse files
committed
[service.libraryautoupdate] 1.2.4
libraryautoupdate performs a connectivity check before scanning the library. Previously, this check fetched www.google.com, which is inappropriate for a connection check. This commit fixes the problem by fetching a static connectivity check page, which returns a 204 status code with an empty response.
1 parent cb2264b commit 517b420

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

service.libraryautoupdate/addon.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
22
<addon id="service.libraryautoupdate"
3-
name="Library Auto Update" version="1.2.3" provider-name="robweber">
3+
name="Library Auto Update" version="1.2.4" provider-name="robweber">
44
<requires>
55
<import addon="xbmc.python" version="3.0.0"/>
66
<import addon="script.module.dateutil" version="2.7.3" />
@@ -78,7 +78,7 @@
7878
<assets>
7979
<icon>resources/media/icon.png</icon>
8080
</assets>
81-
<news>Version 1.2.3
82-
- fix for hourly timer settings not working </news>
81+
<news>Version 1.2.4
82+
- use a connection check URL instead of google.com</news>
8383
</extension>
8484
</addon>

service.libraryautoupdate/resources/lib/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ def databaseUpdated(self, database):
337337

338338
def _networkUp(self):
339339
try:
340-
urlopen('http://www.google.com', timeout=1)
340+
urlopen('http://connectivitycheck.gstatic.com/generate_204', timeout=1)
341341
return True
342342
except Exception:
343343
pass

0 commit comments

Comments
 (0)