Merge pull request #124 from epenet/send_image_error

Add tests for send image error

Author: epenet

tests/const.py

@@ -2,6 +2,8 @@
 
 with open("tests/fixtures/event_d2d_service_message_available.json") as file:
     D2D_SERVICE_MESSAGE_AVAILABLE_SAMPLE = file.read()
+with open("tests/fixtures/event_d2d_service_message_send_image_error.json") as file:
+    D2D_SERVICE_MESSAGE_SEND_IMAGE_ERROR = file.read()
 with open("tests/fixtures/event_ms_channel_connect.json") as file:
     MS_CHANNEL_CONNECT_SAMPLE = file.read()
 with open("tests/fixtures/event_ms_channel_disconnect.json") as file:

tests/fixtures/event_d2d_service_message_send_image_error.json

@@ -0,0 +1,5 @@
+{
+  "data": "{\"id\":\"3d99854f-a8cf-4971-afd6-058b7151da16\",\"event\":\"error\",\"request_data\":\"{\\\"request\\\": \\\"send_image\\\", \\\"file_type\\\": \\\"png\\\", \\\"conn_info\\\": {\\\"d2d_mode\\\": \\\"socket\\\", \\\"connection_id\\\": 2825700145, \\\"id\\\": \\\"3d99854f-a8cf-4971-afd6-058b7151da16\\\"}, \\\"image_date\\\": \\\"2022:04:06 08:52:23\\\", \\\"matte_id\\\": \\\"modern_apricot\\\", \\\"file_size\\\": 16123877, \\\"id\\\": \\\"3d99854f-a8cf-4971-afd6-058b7151da16\\\"}\",\"error_code\":\"-1\",\"target_client_id\":\"ada14710-7e2e-47bb-885b-1715512a2d40\"}",
+  "event": "d2d_service_message",
+  "from": "77151bce-7dd2-4c4c-9b78-4d33b16fb1b"
+}

tests/test_art.py

@@ -1,11 +1,15 @@
 """Tests for art module."""
 from unittest.mock import Mock, patch
 
+import pytest
+
+from samsungtvws import exceptions
 from samsungtvws.art import SamsungTVArt
 from samsungtvws.remote import SamsungTVWS
 
 from .const import (
     D2D_SERVICE_MESSAGE_AVAILABLE_SAMPLE,
+    D2D_SERVICE_MESSAGE_SEND_IMAGE_ERROR,
     MS_CHANNEL_CONNECT_SAMPLE,
     MS_CHANNEL_DISCONNECT_SAMPLE,
     MS_CHANNEL_READY_SAMPLE,
@@ -110,3 +114,29 @@ def test_change_matte(connection: Mock) -> None:
         connection.send.assert_called_once_with(
             '{"method": "ms.channel.emit", "params": {"event": "art_app_request", "to": "host", "data": "{\\"request\\": \\"change_matte\\", \\"content_id\\": \\"test\\", \\"matte_id\\": \\"none\\", \\"id\\": \\"07e72228-7110-4655-aaa6-d81b5188c219\\"}"}}'
         )
+
+
+def test_send_image_failure(connection: Mock) -> None:
+    """Ensure send_image failure raises error and doesn't hang indefinitely."""
+    with patch(
+        "samsungtvws.art.uuid.uuid4",
+        return_value="07e72228-7110-4655-aaa6-d81b5188c219",
+    ), patch("samsungtvws.art.random.randrange", return_value=4091151321):
+        connection.recv.side_effect = [
+            MS_CHANNEL_CONNECT_SAMPLE,
+            MS_CHANNEL_READY_SAMPLE,
+            D2D_SERVICE_MESSAGE_SEND_IMAGE_ERROR,
+        ]
+        tv_art = SamsungTVArt("127.0.0.1")
+
+        with pytest.raises(
+            exceptions.ResponseError,
+            match="`send_image` request failed with error number -1",
+        ):
+            tv_art.upload(
+                b"", file_type="png", matte="none", date="2023:05:02 15:06:39"
+            )
+
+        connection.send.assert_called_once_with(
+            '{"method": "ms.channel.emit", "params": {"event": "art_app_request", "to": "host", "data": "{\\"request\\": \\"send_image\\", \\"file_type\\": \\"png\\", \\"conn_info\\": {\\"d2d_mode\\": \\"socket\\", \\"connection_id\\": 4091151321, \\"id\\": \\"07e72228-7110-4655-aaa6-d81b5188c219\\"}, \\"image_date\\": \\"2023:05:02 15:06:39\\", \\"matte_id\\": \\"none\\", \\"file_size\\": 0, \\"id\\": \\"07e72228-7110-4655-aaa6-d81b5188c219\\"}"}}'
+        )