Add a manual tests target (for stdin redirects)

Maybe later we’ll convert this to actual tests, but right now, no.

Author: Frizlab

Package.swift

@@ -113,6 +113,9 @@ let package = Package(
 			res.append(.target(name: "CGNUSourceExportsForTests", swiftSettings: noSwiftSettings))
 		}
 
+		/* Some manual tests for stdin redirect behavior. */
+		res.append(.executableTarget(name: "ManualTests", dependencies: ["ProcessInvocation"], swiftSettings: noSwiftSettings))
+		
 		return res
 	}()
 )

Sources/ManualTests/main.swift

@@ -0,0 +1,25 @@
+import Foundation
+#if canImport(System)
+import System
+#else
+import SystemPackage
+#endif
+
+import ProcessInvocation
+
+
+
+/* Launch like so:
+ *  echo yolo | ./.build/debug/ManualTests
+ * For some reasons actually typing stuff in the Terminal does not work (probably some buffered read as stdin is not a tty for cat, or some other sh*t I don’t really get).
+ *
+ * Apart from the glitch above, it seems to work correctly when not sending file descriptors.
+ * If we do send fds, not much works… */
+//let fd = FileDescriptor(rawValue: FileHandle(forReadingAtPath: "/dev/null")!.fileDescriptor)
+do {
+	for try await line in ProcessInvocation("/bin/cat", stdinRedirect: .none/*, fileDescriptorsToSend: [fd: fd]*/) {
+		print("From cat: \(line.strLineOrHex())")
+	}
+} catch {
+	print("Failed running the process: \(error)")
+}

Sources/ProcessInvocation/ProcessInvocation.swift

@@ -566,7 +566,7 @@ public struct ProcessInvocation : AsyncSequence {
 		let actualExecutablePath: FilePath
 		if fileDescriptorsToSend.isEmpty {
 			switch stdinRedirect {
-				case .none: (/*nop*/)
+				case .none: p.standardInput = FileHandle.standardInput
 				case .fromNull: p.standardInput = nil
 				case .sendFromReader(let reader):
 					let fd = try Self.readFdOfPipeForStreaming(dataFromReader: reader, maxCacheSize: 32 * 1024 * 1024)
@@ -633,14 +633,15 @@ public struct ProcessInvocation : AsyncSequence {
 			/* We must send the modified stdin in the list of file descriptors to send! */
 			switch stdinRedirect {
 				case .none: fileDescriptorsToSend[.standardInput] = .standardInput
-				case .fromNull: (/*nop*/)
+				case .fromNull:
+					let fd = try Self.readFdOfPipeForStreaming(dataFromReader: DataReader(data: Data()), maxCacheSize: 1)
+					fileDescriptorsToSend[.standardInput] = fd
 				case .sendFromReader(let reader):
 					let fd = try Self.readFdOfPipeForStreaming(dataFromReader: reader, maxCacheSize: 32 * 1024 * 1024)
 					fileDescriptorsToSend[.standardInput] = fd
-//					fdsToCloseAfterRun.insert(fd)
 				case .fromFd(let fd, let shouldClose):
+					assert(shouldClose, "Not giving ownership of fd to send is not supported (from stdin redirect).")
 					fileDescriptorsToSend[.standardInput] = fd
-//					if shouldClose {fdsToCloseAfterRun.insert(fd)}
 			}
 		}