dont prematurely detach client session from broker on goodbye (#266)

Author: om26er

parser.go

@@ -123,6 +123,10 @@ func (v Value) UInt64() (uint64, error) {
 		return val, nil
 	case uint:
 		return uint64(val), nil
+	case uint8:
+		return uint64(val), nil
+	case uint16:
+		return uint64(val), nil
 	case uint32:
 		return uint64(val), nil
 	case int64:

realm.go

@@ -284,17 +284,8 @@ func (r *Realm) ReceiveMessage(baseSession BaseSession, msg messages.Message) er
 
 		return nil
 	case messages.MessageTypeGoodbye:
-		if err := r.dealer.RemoveSession(baseSession.ID()); err != nil {
-			return err
-		}
-
-		client, exists := r.clients.LoadAndDelete(baseSession.ID())
-		if !exists {
-			return fmt.Errorf("goodbye: client does not exist")
-		}
-
 		goodbye := messages.NewGoodBye(CloseGoodByeAndOut, nil)
-		success, err := client.TryWriteMessage(goodbye)
+		success, err := baseSession.TryWriteMessage(goodbye)
 		if err != nil {
 			return err
 		}
@@ -303,7 +294,7 @@ func (r *Realm) ReceiveMessage(baseSession BaseSession, msg messages.Message) er
 			log.Debugf("dropped GOODBYE message for blocked peer: %d", baseSession.ID())
 		}
 
-		_ = client.Close()
+		_ = baseSession.Close()
 		return nil
 	default:
 		return fmt.Errorf("unknown message type: %v", msg.Type())