dont change global var slice, its broken (#262)

Author: om26er

acceptor.go

@@ -28,12 +28,6 @@ var wsProtocols = []string{ //nolint:gochecknoglobals
 	JsonWebsocketProtocol,
 }
 
-var serializersByWSSubProtocol = map[string]serializers.Serializer{ //nolint:gochecknoglobals
-	JsonWebsocketProtocol:    &serializers.JSONSerializer{},
-	MsgpackWebsocketProtocol: &serializers.MsgPackSerializer{},
-	CborWebsocketProtocol:    &serializers.CBORSerializer{},
-}
-
 type WebSocketAcceptor struct {
 	specs map[string]serializers.Serializer
 	once  sync.Once
@@ -43,7 +37,7 @@ type WebSocketAcceptor struct {
 
 func (w *WebSocketAcceptor) init() {
 	if w.specs == nil {
-		w.specs = serializersByWSSubProtocol
+		w.specs = SerializersByWSSubProtocol()
 	}
 }
 
@@ -58,7 +52,7 @@ func (w *WebSocketAcceptor) RegisterSpec(spec SerializerSpec) error {
 
 	_, exists := w.specs[spec.SubProtocol()]
 	if exists {
-		return fmt.Errorf("spec for %s is alraedy registered", spec.SubProtocol())
+		return fmt.Errorf("spec for %s is already registered", spec.SubProtocol())
 	}
 
 	w.specs[spec.SubProtocol()] = spec.Serializer()

helpers.go

@@ -211,3 +211,11 @@ func constructSendingMsgLog(msg messages.Message) string {
 		return fmt.Sprintf("[%s] TX: %+v", timestamp, msg.Marshal())
 	}
 }
+
+func SerializersByWSSubProtocol() map[string]serializers.Serializer {
+	return map[string]serializers.Serializer{
+		JsonWebsocketProtocol:    &serializers.JSONSerializer{},
+		MsgpackWebsocketProtocol: &serializers.MsgPackSerializer{},
+		CborWebsocketProtocol:    &serializers.CBORSerializer{},
+	}
+}

joiner.go

@@ -44,7 +44,7 @@ func (w *WebSocketJoiner) Join(ctx context.Context, url, realm string, config *W
 	if w.SerializerSpec != nil {
 		serializer = w.SerializerSpec.Serializer()
 	} else {
-		serializer = serializersByWSSubProtocol[subprotocol]
+		serializer = SerializersByWSSubProtocol()[subprotocol]
 	}
 
 	return Join(peer, realm, serializer, w.Authenticator)