WIP export to XVA after install, and use it for separate firstboot test

FIXME:
- settle for a location to save XVA?
- move to fixture

Author: ydirson

conftest.py

@@ -394,16 +394,21 @@ def create_vms(request, host):
         raise Exception("No vm_definitions marker specified.")
     for vm_def in marker.args:
         assert "name" in vm_def
-        assert "template" in vm_def
-        # FIXME should check optional vdis contents
+        assert "template" in vm_def or "image" in vm_def
+        if "template" in vm_def:
+            assert not "image" in vm_def
+            # FIXME should check optional vdis contents
         # FIXME should check for extra args
 
     try:
         vms = []
         vdis = []
         vbds = []
         for vm_def in marker.args:
-            _create_vm(vm_def, host, vms, vdis, vbds)
+            if "template" in vm_def:
+                _create_vm(vm_def, host, vms, vdis, vbds)
+            elif "image" in vm_def:
+                _import_vm(vm_def, host, vms)
         yield vms
 
     except Exception:
@@ -451,6 +456,12 @@ def _create_vm(marker, host, vms, vdis, vbds):
             logging.info("Setting param %s", param_def)
             vm.param_set(**param_def)
 
+def _import_vm(marker, host, vms):
+    vm_name = marker["name"]
+    vm_image = marker["image"]
+    vm = host.import_vm(vm_image)
+    vms.append(vm)
+
 @pytest.fixture(scope="module")
 def running_vm(imported_vm):
     vm = imported_vm

tests/install/test.py

@@ -83,12 +83,8 @@ def test_install_821_uefi(self, iso_remaster, create_vms):
                                          ).returncode == 1,
                      "Wait for installer to terminate")
 
-            # powercycle, catch any change of IP
             logging.info("Shutting down Host VM after successful installation")
             try:
-                # use "poweroff" because "reboot" would cause ARP and
-                # SSH to be checked before host is down, and require
-                # ssh retries
                 host_vm.ssh(["poweroff"])
             except commands.SSHCommandFailed as e:
                 # ignore connection closed by reboot
@@ -100,12 +96,42 @@ def test_install_821_uefi(self, iso_remaster, create_vms):
             wait_for(host_vm.is_halted, "Wait for host VM halted")
             host_vm.eject_cd()
 
-            # FIXME: make a snapshot here
+        except Exception as e:
+            logging.critical("caught exception %s", e)
+            # wait_for(lambda: False, 'Wait "forever"', timeout_secs=100*60)
+            host_vm.shutdown(force=True)
+            raise
+        except KeyboardInterrupt:
+            logging.warning("keyboard interrupt")
+            # wait_for(lambda: False, 'Wait "forever"', timeout_secs=100*60)
+            host_vm.shutdown(force=True)
+            raise
+
+        # record this state
+        # FIXME move to fixture
+        # FIXME where to store?
+        host_vm.host.ssh(["rm -f test_install_821_uefi-vm1.xva"])
+        host_vm.export("test_install_821_uefi-vm1.xva", "zstd")
 
+    @pytest.mark.vm_definitions(
+        dict(name="vm 1",
+             image="test_install_821_uefi-vm1.xva"
+             ))
+    def test_firstboot_821_uefi(self, create_vms):
+        host_vm = create_vms[0]
+        vif = host_vm.vifs()[0]
+        mac_address = vif.param_get('MAC')
+        logging.info("Host VM has MAC %s", mac_address)
+
+        try:
             # FIXME: evict MAC from ARP cache first?
             host_vm.start()
             wait_for(host_vm.is_running, "Wait for host VM running")
 
+            # catch host-vm IP address
+            wait_for(lambda: pxe.arp_addresses_for(mac_address),
+                     "Wait for DHCP server to see Host VM in ARP tables",
+                     timeout_secs=10*60)
             ips = pxe.arp_addresses_for(mac_address)
             logging.info("Host VM has IPs %s", ips)
             assert len(ips) == 1
@@ -187,3 +213,9 @@ def test_install_821_uefi(self, iso_remaster, create_vms):
             # wait_for(lambda: False, 'Wait "forever"', timeout_secs=100*60)
             host_vm.shutdown(force=True)
             raise
+
+        # record this state
+        # FIXME move to fixture
+        # FIXME where to store?
+        host_vm.host.ssh(["rm -f test_firstboot_821_uefi-vm1.xva"])
+        host_vm.export("test_firstboot_821_uefi-vm1.xva", "zstd")