ssh: stop returning an unused Popen object in "background" mode

ydirson · ydirson · commit 0ec67e844114 · 2025-03-25T19:17:11.000+01:00
When we launch a process "in background on server side" the local ssh
process will exit very quickly and we won't need much from the Popen object,
which was actually ignored in caller code.

Signed-off-by: Yann Dirson &lt;yann.dirson@vates.tech&gt;
diff --git a/lib/commands.py b/lib/commands.py
@@ -97,7 +97,7 @@ def _ssh(hostname_or_ip, cmd, check, simple_output, suppress_fingerprint_warning
         stderr=subprocess.STDOUT
     )
     if background:
-        return True, process
+        return True, None
 
     stdout = []
     for line in iter(process.stdout.readline, b''):

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ def _ssh(hostname_or_ip, cmd, check, simple_output, suppress_fingerprint_warning`
`97`	`97`	`stderr=subprocess.STDOUT`
`98`	`98`	`)`
`99`	`99`	`if background:`
`100`		`- return True, process`
	`100`	`+ return True, None`
`101`	`101`
`102`	`102`	`stdout = []`
`103`	`103`	`for line in iter(process.stdout.readline, b''):`