tests/storage/linstor: Added test_linstor_sr_expand_disk to detect suitable disk(s) and expand LVM of Linstor SR across hosts.

The test:
- Ensures `--expansion-sr-disk` disk(s) are available on the hosts.
- Configures LVM onto it and integrates into Linstor SR pool.
- Expands SR capacity and validates the increase.

Signed-off-by: Rushikesh Jadhav <[email protected]>

Author: rushikeshjadhav

tests/storage/linstor/test_linstor_sr.py

@@ -2,7 +2,7 @@
 import pytest
 import time
 
-from .conftest import LINSTOR_PACKAGE
+from .conftest import GROUP_NAME, LINSTOR_PACKAGE
 from lib.commands import SSHCommandFailed
 from lib.common import wait_for, vm_image
 from tests.storage import vdi_is_open
@@ -86,6 +86,63 @@ def test_snapshot(self, vm_on_linstor_sr):
         finally:
             vm.shutdown(verify=True)
 
+    @pytest.mark.small_vm
+    def test_linstor_sr_expand_disk(self, linstor_sr, provisioning_type, storage_pool_name,
+                                    pytestconfig, vm_on_linstor_sr):
+        """
+        This test demonstrates online expansion of a LINSTOR SR while a VM is actively running on it.
+
+        It identifies hosts within the same pool, detects free raw disks, and expands the LVM to grow the SR.
+        A VM is started before the expansion, and its functionality is verified through a shutdown and restart
+        after the expansion completes successfully.
+        """
+        sr = linstor_sr
+        vm = vm_on_linstor_sr
+        vm.start()
+        sr_size = sr.pool.master.xe('sr-param-get', {'uuid': sr.uuid, 'param-name': 'physical-size'})
+        resized = False
+        disks = []
+        for h in sr.pool.hosts:
+            logging.info("Checking on {}".format(h.hostname_or_ip))
+            available_disks = h.available_disks()
+            # We need the disk to be "raw" (non LVM_member etc) to use
+            available_disks = [disk for disk in available_disks if h.raw_disk_is_available(disk)]
+            expansion_sr_disk = pytestconfig.getoption("expansion_sr_disk")
+            if expansion_sr_disk:
+                assert len(expansion_sr_disk) == 1, "This test requires only one --expansion-sr-disk parameter"
+                if "auto" == expansion_sr_disk[0]:
+                    disks = available_disks
+                else:
+                    assert expansion_sr_disk[0] in available_disks, "The expansion-sr-disk seems unavailable"
+                    disks = expansion_sr_disk
+            else:
+                disks = available_disks
+            for disk in disks:
+                logging.info("Found Disk {}".format(disk))
+                device = '/dev/' + disk
+                try:
+                    h.ssh(['pvcreate', device])
+                    h.ssh(['vgextend', GROUP_NAME, device])
+                    if provisioning_type == "thin":
+                        h.ssh(['lvextend', '-l', '+100%FREE', storage_pool_name])
+                    else: # Needed service restart for thick pool sr scan
+                        h.ssh('systemctl restart linstor-satellite.service')
+                    resized = True
+                    logging.info("Successfully expanded LVM on %s with %s", h.hostname_or_ip, device)
+                except SSHCommandFailed as e:
+                    raise e
+
+        # Need to ensure that linstor is healthy/up-to-date before moving ahead.
+        time.sleep(30) # Wait time for Linstor node communications to restore.
+        sr.scan()
+        new_sr_size = sr.pool.master.xe('sr-param-get', {'uuid': sr.uuid, 'param-name': 'physical-size'})
+        assert int(new_sr_size) > int(sr_size) and resized is True, \
+            f"Expected SR size to increase but got old size: {sr_size}, new size: {new_sr_size}"
+        logging.info("SR expansion completed")
+        vm.shutdown(verify=True)
+        # Ensure VM is able to start and shutdown on expanded SR
+        self.test_start_and_shutdown_VM(vm)
+
     # *** tests with reboots (longer tests).
 
     @pytest.mark.reboot