Add early check of mandatory fields in *_device_config() fixtures

Signed-off-by: Yann Dirson <[email protected]>

Author: ydirson

lib/config.py

@@ -1,6 +1,10 @@
 ignore_ssh_banner = False
 ssh_output_max_lines = 20
 
-def sr_device_config(datakey):
+def sr_device_config(datakey, *, required=[]):
     import data # import here to avoid depending on this user file for collecting tests
-    return getattr(data, datakey)
+    config = getattr(data, datakey)
+    for required_field in required:
+        if required_field not in config:
+            raise Exception(f"{datakey} lacks mandatory {required_field!r}")
+    return config

tests/storage/iso/conftest.py

@@ -26,7 +26,7 @@ def local_iso_sr(host, formatted_and_mounted_ext4_disk):
 
 @pytest.fixture(scope='module')
 def nfs_iso_device_config():
-    return config.sr_device_config("NFS_ISO_DEVICE_CONFIG")
+    return config.sr_device_config("NFS_ISO_DEVICE_CONFIG", required=['location'])
 
 @pytest.fixture(scope='module')
 def cifs_iso_device_config():