Skip to content

Commit 273939f

Browse files
authored
Merge pull request #303 from xcp-ng/misc-fixes
Misc fixes
2 parents 9020b5d + d4aa199 commit 273939f

File tree

3 files changed

+42
-37
lines changed

3 files changed

+42
-37
lines changed

.github/workflows/code-checkers.yml

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
name: Static code checkers
2+
3+
on: [push]
4+
5+
jobs:
6+
mypy:
7+
runs-on: ubuntu-latest
8+
steps:
9+
- uses: actions/checkout@v2
10+
- name: Set up Python
11+
uses: actions/setup-python@v4
12+
with:
13+
python-version: 3.8
14+
- name: Install dependencies
15+
run: |
16+
python -m pip install --upgrade pip
17+
pip install -r requirements/base.txt
18+
pip install mypy
19+
- name: Create a dummy data.py
20+
run: cp data.py-dist data.py
21+
- name: Check with mypy
22+
run: mypy lib/ tests/
23+
24+
pyright:
25+
runs-on: ubuntu-latest
26+
steps:
27+
- uses: actions/checkout@v2
28+
- name: Set up Python
29+
uses: actions/setup-python@v4
30+
with:
31+
python-version: 3.8
32+
- name: Install dependencies
33+
run: |
34+
python -m pip install --upgrade pip
35+
pip install -r requirements/base.txt
36+
pip install pyright
37+
- name: Create a dummy data.py
38+
run: cp data.py-dist data.py
39+
- name: Check with pyright
40+
run: pyright lib/ # tests/

.github/workflows/jobs-check.yml

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -19,39 +19,3 @@ jobs:
1919
run: cp data.py-dist data.py
2020
- name: jobs-check
2121
run: ./jobs.py check
22-
23-
mypy:
24-
runs-on: ubuntu-latest
25-
steps:
26-
- uses: actions/checkout@v2
27-
- name: Set up Python
28-
uses: actions/setup-python@v4
29-
with:
30-
python-version: 3.8
31-
- name: Install dependencies
32-
run: |
33-
python -m pip install --upgrade pip
34-
pip install -r requirements/base.txt
35-
pip install mypy
36-
- name: Create a dummy data.py
37-
run: cp data.py-dist data.py
38-
- name: Check with mypy
39-
run: mypy lib/ tests/
40-
41-
pyright:
42-
runs-on: ubuntu-latest
43-
steps:
44-
- uses: actions/checkout@v2
45-
- name: Set up Python
46-
uses: actions/setup-python@v4
47-
with:
48-
python-version: 3.8
49-
- name: Install dependencies
50-
run: |
51-
python -m pip install --upgrade pip
52-
pip install -r requirements/base.txt
53-
pip install pyright
54-
- name: Create a dummy data.py
55-
run: cp data.py-dist data.py
56-
- name: Check with pyright
57-
run: pyright lib/ # tests/

jobs.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,8 @@
270270
"description": "tests certificate propagation to disk by XAPI, and to VMs by uefistored/varstored",
271271
"requirements": [
272272
"A pool >= 8.2.1. On 8.3+, it needs at least two hosts. On 8.2, one is enough but more is better.",
273-
"On 8.3+ only, a second pool, single-host, available for temporarily joining the first pool.",
273+
"On 8.3+ only, a second pool, single-host, available for temporarily joining the first pool"
274+
"and rebooting once ejected.",
274275
"A fast-booting unix UEFI VM with efitools.",
275276
"An additional free disk on the first host.",
276277
],

0 commit comments

Comments
 (0)