Skip to content

Commit 28b021a

Browse files
committed
test_basic_without_ssh: use a fixture instead of expecting test_start
"test_start" was never a real test here, turning it into official fixture makes sure that the VM is started for any test. There is no other inter-test dependency in this file, this allows to stop using @pytest.mark.incremental here. Signed-off-by: Yann Dirson <[email protected]>
1 parent 9e50c74 commit 28b021a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/misc/test_basic_without_ssh.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ def existing_shared_sr(host):
2525
assert sr is not None, "A shared SR on the pool is required"
2626
return sr
2727

28-
@pytest.mark.incremental # tests depend on each other. If one test fails, don't execute the others
2928
@pytest.mark.multi_vms # run them on a variety of VMs
3029
@pytest.mark.big_vm # and also on a really big VM ideally
3130
class TestBasicNoSSH:
32-
def test_start(self, imported_vm):
31+
@pytest.fixture(scope="class", autouse=True)
32+
def vm_start(self, imported_vm):
3333
vm = imported_vm
3434
# if VM already running, stop it
3535
if (vm.is_running()):

0 commit comments

Comments
 (0)