guest-tools/win: Work around vanishing CD drive

Signed-off-by: Tu Dinh <[email protected]>

Author: dinhngtu

tests/guest-tools/win/__init__.py

@@ -1,9 +1,11 @@
 import enum
 import logging
 import re
+import time
 from typing import Any
 
 from data import ISO_DOWNLOAD_URL
+from lib.commands import SSHCommandFailed
 from lib.common import wait_for
 from lib.host import Host
 from lib.sr import SR
@@ -77,10 +79,21 @@ def insert_cd_safe(vm: VM, vdi_name: str, cd_path="D:/", retries=2):
     If this happens, reboot the VM in hopes that it will be detected.
     """
     for _attempt in range(retries):
+        # Eject the existing CD just in case.
+        try:
+            vm.eject_cd()
+            # Leave some time for the guest to realize its CD got ejected.
+            time.sleep(5)
+        except SSHCommandFailed:
+            pass
+
         vm.insert_cd(vdi_name)
+        if not vm.is_running():
+            vm.start()
         # wait_for(vm.file_exists) doesn't handle SSHCommandFailed;
         # we need to check for it via wait_for(vm.is_ssh_up).
         wait_for_vm_running_and_ssh_up_without_tools(vm)
+
         try:
             wait_for(lambda: vm.file_exists(cd_path, regular_file=False), timeout_secs=60)
             return
@@ -89,7 +102,5 @@ def insert_cd_safe(vm: VM, vdi_name: str, cd_path="D:/", retries=2):
             # There might be no VM tools so use SSH instead.
             vm.ssh(WINDOWS_SHUTDOWN_COMMAND)
             wait_for(vm.is_halted, "Wait for VM halted")
-            vm.eject_cd()
-            vm.start()
-            wait_for_vm_running_and_ssh_up_without_tools(vm)
+
     raise TimeoutError(f"Waiting for CD at {cd_path} failed")

tests/guest-tools/win/guest_tools.py

@@ -29,6 +29,12 @@ def install_guest_tools(vm: VM, guest_tools_iso: dict[str, Any], action: PowerAc
         rootcert = PureWindowsPath("D:\\") / guest_tools_iso["testsign_cert"]
         enable_testsign(vm, rootcert)
 
+        # HACK: Sometimes after rebooting the CD drive just vanishes. Check for it again and
+        # reboot/reinsert CD if needed.
+        if not vm.file_exists("D:/", regular_file=False):
+            logging.warning("CD drive not detected, retrying")
+            insert_cd_safe(vm, guest_tools_iso["name"])
+
     logging.info("Copy Windows PV drivers to VM")
     package_path = PureWindowsPath("D:\\") / guest_tools_iso["package"]
     vm.execute_powershell_script(f"Copy-Item -Force '{package_path}' '{GUEST_TOOLS_COPY_PATH}'")

tests/guest-tools/win/other_tools.py

@@ -24,6 +24,12 @@ def install_other_drivers(vm: VM, other_tools_iso_name: str, param: dict[str, An
             rootcert = PureWindowsPath("D:\\") / param["path"] / param["testsign_cert"]
             enable_testsign(vm, rootcert)
 
+            # HACK: Sometimes after rebooting the CD drive just vanishes. Check for it again and
+            # reboot/reinsert CD if needed.
+            if not vm.file_exists("D:/", regular_file=False):
+                logging.warning("CD drive not detected, retrying")
+                insert_cd_safe(vm, other_tools_iso_name)
+
         package_path = PureWindowsPath("D:\\") / param["path"] / param["package"]
         install_cmd = "D:\\install-drivers.ps1 "
         if driver_type == "msi":