Skip to content

Commit 3d904d9

Browse files
committed
Use unused_disks in ext tests
Signed-off-by: Yann Dirson <[email protected]>
1 parent b98952a commit 3d904d9

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

pkgfixtures.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@
1919

2020
# package scope because previous test packages may have used the disk
2121
@pytest.fixture(scope='package')
22-
def sr_disk_wiped(host: Host, sr_disk: DiskDevName) -> Generator[DiskDevName]:
22+
def sr_disk_wiped(host: Host, unused_disks: dict[Host, list[DiskDevName]]) -> Generator[DiskDevName]:
2323
"""A disk on MASTER HOST OF FIRST POOL which we wipe."""
24+
sr_disk = unused_disks[host][0]
2425
logging.info(">> wipe disk %s" % sr_disk)
2526
host.ssh(['wipefs', '-a', '/dev/' + sr_disk])
2627
yield sr_disk

tests/storage/ext/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
import pytest
33

44
@pytest.fixture(scope='package')
5-
def ext_sr(host, sr_disk):
5+
def ext_sr(host, unused_disks):
66
""" An EXT SR on first host. """
7+
sr_disk = unused_disks[host][0]
78
sr = host.sr_create('ext', "EXT-local-SR-test", {'device': '/dev/' + sr_disk})
89
yield sr
910
# teardown

tests/storage/ext/test_ext_sr.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ class TestEXTSRCreateDestroy:
1515
def test_create_sr_with_missing_device(self, host):
1616
try_to_create_sr_with_missing_device('ext', 'EXT-local-SR-test', host)
1717

18-
def test_create_and_destroy_sr(self, host, sr_disk):
18+
def test_create_and_destroy_sr(self, host, unused_disks):
1919
# Create and destroy tested in the same test to leave the host as unchanged as possible
20+
sr_disk = unused_disks[host][0]
2021
sr = host.sr_create('ext', "EXT-local-SR-test", {'device': '/dev/' + sr_disk}, verify=True)
2122
# import a VM in order to detect vm import issues here rather than in the vm_on_xfs_fixture used in
2223
# the next tests, because errors in fixtures break teardown

0 commit comments

Comments
 (0)