WIP install 6/n: use iso-remaster to plug an answerfile

FIXME:
- hardcoded config values
- hardcoded HTTP answerfile, not generated

Author: ydirson

conftest.py

@@ -1,11 +1,13 @@
 import logging
+import os
 import pytest
 import tempfile
 
 from packaging import version
 
 import lib.config as global_config
 
+from lib.commands import local_cmd, scp, ssh
 from lib.common import wait_for, vm_image, is_uuid
 from lib.common import setup_formatted_and_mounted_disk, teardown_formatted_and_mounted_disk
 from lib.netutil import is_ipv6
@@ -254,6 +256,75 @@ def sr_disk_for_all_hosts(request, host):
         logging.info(f">> Disk or block device {disk} is present and free on all pool members")
     yield candidates[0]
 
+@pytest.fixture(scope='session')
+def iso_remaster():
+    SOURCE_ISO = "/home/user/iso/xcp-ng-8.2.1-20231130.iso" # FIXME dict in data.py
+    ANSWERFILE_URL = "http://pxe/configs/custom/ydi/install-8.2-uefi-iso-ext.xml" # FIXME
+
+    from data import ISOSR_SRV, ISOSR_PATH, TOOLS
+    assert "iso-remaster" in TOOLS
+    iso_remaster = TOOLS["iso-remaster"]
+    assert os.access(iso_remaster, os.X_OK)
+
+    with tempfile.TemporaryDirectory() as isotmp:
+        remastered_iso = os.path.join(isotmp, "image.iso")
+        iso_patcher_script = os.path.join(isotmp, "iso-patcher")
+
+        logging.info("Remastering %s to %s", SOURCE_ISO, remastered_iso)
+
+        # generate install.img-patcher script
+        with open(img_patcher_script, "xt") as patcher_fd:
+            print(f"""#!/bin/bash
+set -ex
+INSTALLIMG="$1"
+
+curl {ANSWERFILE_URL} -o "$INSTALLIMG/root/answerfile.xml"
+""",
+                  file=patcher_fd)
+            os.chmod(patcher_fd.fileno(), 0o755)
+
+        # generate iso-patcher script
+        with open(iso_patcher_script, "xt") as patcher_fd:
+            passwd = "passw0rd" # FIXME hash
+            print(f"""#!/bin/bash
+set -ex
+ISODIR="$1"
+SED_COMMANDS=(-e "s@/vmlinuz@/vmlinuz sshpassword={passwd} atexit=shell@")
+SED_COMMANDS+=(-e "s@/vmlinuz@/vmlinuz install answerfile=file:///root/answerfile.xml network_device=all@")
+
+sed -i "${{SED_COMMANDS[@]}}" \
+    "$ISODIR"/*/*/grub*.cfg \
+    "$ISODIR"/boot/isolinux/isolinux.cfg
+""",
+                  file=patcher_fd)
+            os.chmod(patcher_fd.fileno(), 0o755)
+
+        # do remaster
+        local_cmd([iso_remaster,
+                   "--iso-patcher", iso_patcher_script,
+                   SOURCE_ISO, remastered_iso
+                   ])
+
+        # unique filename on server, has to work on FreeBSD-based NAS
+        # too, and even v14 has no tool allowing mktemp suffixes
+        remote_iso = ssh(ISOSR_SRV,
+                         ["python3", "-c",
+                          '"import os, tempfile; '
+                          f"f = tempfile.mkstemp(suffix='.iso', dir='{ISOSR_PATH}')[1];"
+                          "os.chmod(f, 0o644);"
+                          'print(f);"'
+                          ])
+        logging.info("Uploading to ISO-SR server remastered %s as %s",
+                     remastered_iso, os.path.basename(remote_iso))
+        scp(ISOSR_SRV, remastered_iso, remote_iso)
+        # FIXME: is sr-scan ever needed?
+
+    try:
+        yield os.path.basename(remote_iso)
+    finally:
+        logging.info("Removing %s from ISO-SR server", os.path.basename(remote_iso))
+        ssh(ISOSR_SRV, ["rm", remote_iso])
+
 @pytest.fixture(scope='module')
 def vm_ref(request):
     ref = request.param

data.py-dist

@@ -26,6 +26,15 @@ PXE_CONFIG_SERVER = 'pxe'
 # Default VM images location
 DEF_VM_URL = 'http://pxe/images/'
 
+# Default shared ISO SR
+ISOSR_SRV = "nfs-server"
+ISOSR_PATH = "/srv/iso-sr"
+
+# Tools
+TOOLS = {
+#    "iso-remaster": "/home/user/src/xcpng/xcp/scripts/iso-remaster/iso-remaster.sh",
+}
+
 # Values can be either full URLs or only partial URLs that will be automatically appended to DEF_VM_URL
 VM_IMAGES = {
     'mini-linux-x86_64-bios': 'alpine-minimal-3.12.0.xva',

tests/install/test_install.py

@@ -17,9 +17,9 @@ class TestInstallNested:
              vdis=[dict(name="vm 1 system disk", size="100GiB", device="xvda", userdevice="0")],
              vifs=[dict(index=0, network_uuid="eabc1038-e40f-2ae5-0781-a3adbec1cae8")], # FIXME
              ))
-    def test_install_nested_821_uefi(self, create_vms):
+    def test_install_nested_821_uefi(self, iso_remaster, create_vms):
         assert len(create_vms) == 1
         host_vm = create_vms[0]
 
         host_vm.create_cd_vbd(device="xvdd", userdevice="3")
-        host_vm.insert_cd("xcp-ng-8.2.1-20231130.iso")
+        host_vm.insert_cd(iso_remaster)