Drop now-unused sr_disk fixture and flag

Signed-off-by: Yann Dirson <[email protected]>

Author: ydirson

conftest.py

@@ -129,7 +129,6 @@ def pytest_collection_modifyitems(items, config):
         'windows_vm',
         'hostA2',
         'hostB1',
-        'sr_disk',
         'sr_disk_4k',
         'unused_512B_disks',
     ]
@@ -404,30 +403,6 @@ def unused_512B_disks(disks: dict[Host, list[Host.BlockDeviceInfo]]
     logging.debug("available disks collected: %s", {host.hostname_or_ip: value for host, value in ret.items()})
     return ret
 
-@pytest.fixture(scope='session')
-def sr_disk(pytestconfig, host: Host) -> Generator[DiskDevName]:
-    """
-    Disk DEVICE NAME available on FIRST POOL MASTER.
-
-    Abort if not exactly one --sr_disk.  If --sr_disk=auto take any, else
-    return requested device (abort if not present).
-    """
-    disks = pytestconfig.getoption("sr_disk")
-    if len(disks) != 1:
-        pytest.fail("This test requires exactly one --sr-disk parameter")
-    disk = disks[0]
-    if disk == "auto":
-        logging.info(">> Check for the presence of a free disk device on the master host")
-        disks = host.available_disks()
-        assert len(disks) > 0, "a free disk device is required on the master host"
-        disk = disks[0]
-        logging.info(f">> Found free disk device(s) on hostA1: {' '.join(disks)}. Using {disk}.")
-    else:
-        logging.info(f">> Check that disk or block device {disk} is available on the master host")
-        assert disk in host.available_disks(), \
-            f"disk or block device {disk} is either not present or already used on master host"
-    yield disk
-
 @pytest.fixture(scope='session')
 def sr_disk_4k(pytestconfig, host: Host) -> Generator[DiskDevName]:
     """

pytest.ini

@@ -9,7 +9,6 @@ markers =
     # * Host-related markers, automatically set based on fixtures
     hostA2: a second member in the first pool.
     hostB1: a second pool.
-    sr_disk: the test needs a free disk or writable block device that it can erase.
     sr_disk_4k: the test needs a free 4KiB block device that it can erase.
     unused_512B_disks: the test needs one or more free 512B-blocks disk or writable block device that it can erase.