WIP: Implement storage nfs-on-slave test

This new test ensure that the "nfs-on-slave" host-plugin does
check something, and return different result based on the environment.

TODO: Still need to figure out how to find the type of VDI, to have
the extension for the path. It's currently hard-coded to .vhd.

Signed-off-by: Anthony PERARD <[email protected]>

Author: tperard

tests/storage/nfs/test_nfs_sr.py

@@ -1,6 +1,13 @@
 import pytest
+from lib.commands import SSHCommandFailed
 from lib.common import wait_for, vm_image
+from lib.vdi import VDI
+import logging
 from tests.storage import vdi_is_open
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from lib.vm import VM
 
 # Requirements:
 # - one XCP-ng host >= 8.0 with an additional unused disk for the SR
@@ -29,6 +36,42 @@ def test_vdi_is_not_open(self, dispatch_nfs):
         vdi = dispatch_nfs
         assert not vdi_is_open(vdi)
 
+    @pytest.mark.small_vm
+    @pytest.mark.usefixtures('hostA2')
+    # Make sure this fixture is called before the parametrized one
+    @pytest.mark.usefixtures('vm_ref')
+    @pytest.mark.parametrize('dispatch_nfs', ['vm_on_nfs_sr'], indirect=True)
+    def test_plugin_nfs_on_on_slave(self, dispatch_nfs: 'VM'):
+        vm = dispatch_nfs
+        vm.start()
+        vm.wait_for_os_booted()
+        host = vm.get_residence_host()
+
+        vdi = VDI(vm.vdi_uuids()[0], host=host)
+
+        # TODO: How to find out if it's .vhd?
+        vdi_path = f"/run/sr-mount/{vdi.sr.uuid}/{vdi.uuid}.vhd"
+
+        # nfs-on-slave returns an error when the VDI is open on the host.
+        # Otherwise, it return "success", including in case "path" doesn't exist
+        try:
+            assert vm.is_running_on_host(host)
+            host.call_plugin("nfs-on-slave", "check", {"path": vdi_path})
+            assert False, "nfs-on-slave should have returned an error"
+        except SSHCommandFailed as e:
+            # The output of the host plugin would have "stdout: NfsCheckException"
+            # and information about which process have the path open.
+            assert "NfsCheckException" in e.stdout
+            logging.debug(f"nfs-on-slave returns a failure as expected")
+
+        for member in host.pool.hosts:
+            # skip the host where the VM is running
+            if member.uuid == host.uuid:
+                continue
+            member.call_plugin("nfs-on-slave", "check", {"path": vdi_path})
+
+        vm.shutdown(verify=True)
+
     @pytest.mark.small_vm # run with a small VM to test the features
     @pytest.mark.big_vm # and ideally with a big VM to test it scales
     # Make sure this fixture is called before the parametrized one