WIP don't export on failure

should likely be part of the "fixup! WIP export to XVA after install"

Author: ydirson

conftest.py

@@ -446,12 +446,19 @@ def create_vms(request, host):
                 _import_vm(vm_def, host, vms, use_cache=CACHE_IMPORTED_VM)
         yield vms
 
-        # record this state
-        for vm_def, vm in zip(vm_defs, vms):
-            # FIXME where to store?
-            xva_name = f"{shortened_nodeid(request.node.nodeid)}-{vm_def['name']}.xva"
-            host.ssh(["rm -f", xva_name])
-            vm.export(xva_name, "zstd", use_cache=CACHE_IMPORTED_VM)
+        # request.node is an "item" because this fixture has "function" scope
+        report = request.node.stash[PHASE_REPORT_KEY]
+        if report["setup"].failed:
+            logging.warning("setting up a test failed or skipped: not exporting VMs")
+        elif ("call" not in report) or report["call"].failed:
+            logging.warning("executing test failed or skipped: not exporting VMs")
+        else:
+            # record this state
+            for vm_def, vm in zip(vm_defs, vms):
+                # FIXME where to store?
+                xva_name = f"{shortened_nodeid(request.node.nodeid)}-{vm_def['name']}.xva"
+                host.ssh(["rm -f", xva_name])
+                vm.export(xva_name, "zstd", use_cache=CACHE_IMPORTED_VM)
 
     except Exception:
         logging.error("exception caught...")