Support ty as type checker

ty is much faster than pyright or mypy.

It's not able to detect the missing typehints on arguments and return
values, but fortunately ruff has that feature.

Pytest is updated to 9.0.2 to fix the type error on pytest.fail,
pytest.xfail and pytest.skip.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>

Author: glehmann

.github/workflows/code-checkers.yml

@@ -31,6 +31,19 @@ jobs:
         run: cp vm_data.py-dist vm_data.py
       - run: pyright .
 
+  ty:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8  # 6.0.1
+        with:
+          persist-credentials: false
+      - uses: ./.github/actions/uv-setup/
+      - name: Create a dummy data.py
+        run: cp data.py-dist data.py
+      - name: Create a dummy vm_data.py
+        run: cp vm_data.py-dist vm_data.py
+      - run: ty check .
+
   ruff:
     runs-on: ubuntu-latest
     env:

lib/config.py

@@ -1,7 +1,7 @@
 
 
-ignore_ssh_banner = False
-ssh_output_max_lines = 20
+ignore_ssh_banner: bool = False
+ssh_output_max_lines: int = 20
 
 def sr_device_config(datakey: str, *, required: list[str] = []) -> dict[str, str]:
     import data  # import here to avoid depending on this user file for collecting tests

pyproject.toml

@@ -31,13 +31,17 @@ dev = [
     "types-pygments",
     "types-colorama",
     "types-pexpect",
+    "ty",
 ]
 
 [tool.pyright]
 typeCheckingMode = "standard"
 reportMissingParameterType = "error"
 reportUnknownParameterType = "error"
 
+[tool.ty.rules]
+unused-type-ignore-comment = "ignore"
+
 [tool.ruff]
 preview = true
 line-length = 120
@@ -53,9 +57,11 @@ select = [
   "I",  # isort
   "SLF",  # flake8-self
   "SIM",  # flake8-simplify
+  "ANN",  # flake8-annotations
 ]
 # don't use some of the default D and SIM rules
 ignore = [
+  "ANN401",  # missing-return-type-special-method. Might be removed later.
   "D100",  # undocumented-public-module
   "D101",  # undocumented-public-class
   "D102",  # undocumented-public-method
@@ -76,6 +82,7 @@ ignore = [
   "SIM105",  # suppressible-exception
   "SIM108",  # if-else-block-instead-of-if-exp
 ]
+flake8-annotations.mypy-init-return = true
 
 # restrict to the PEP 257 rules
 pydocstyle.convention = "pep257"

requirements/dev.txt

@@ -12,4 +12,5 @@ libarchive-c==5.3
 types-pygments
 types-colorama
 types-pexpect
+ty
 -r base.txt

scripts/xva_bridge.py

@@ -19,19 +19,19 @@ def __init__(self, member: minidom.Element):
 
     def get_name(self) -> str | None:
         for child in self.member.childNodes:
-            if child.nodeType == minidom.Node.ELEMENT_NODE and child.tagName == "name" and child.firstChild:
+            if isinstance(child, minidom.Element) and child.tagName == "name" and child.firstChild:
                 return child.firstChild.nodeValue
         return None
 
     def get_value(self) -> str | None:
         for child in self.member.childNodes:
-            if child.nodeType == minidom.Node.ELEMENT_NODE and child.tagName == "value" and child.firstChild:
+            if isinstance(child, minidom.Element) and child.tagName == "value" and child.firstChild:
                 return child.firstChild.nodeValue
         return None
 
     def set_value(self, value: str) -> None:
         for child in self.member.childNodes:
-            if child.nodeType == minidom.Node.ELEMENT_NODE and child.tagName == "value" and child.firstChild:
+            if isinstance(child, minidom.Element) and child.tagName == "value" and child.firstChild:
                 child.firstChild.nodeValue = value  # type: ignore
         return None