Skip to content

Commit 96e01d1

Browse files
authored
Merge pull request #283 from xcp-ng/fix-vm-vdi_uuids
Fix `VM.vdi_uuids`
2 parents 3052845 + 81b669f commit 96e01d1

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

lib/basevm.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,10 @@ def name(self):
4040

4141
def vdi_uuids(self, sr_uuid=None):
4242
output = self._disk_list()
43-
all_uuids = output.split(',') # Split based on commas
44-
# Select only every alternate UUID (even index positions)
45-
vdis = all_uuids[0::2] # Start at 0, step by 2
43+
if output == '':
44+
return []
45+
46+
vdis = output.split(',')
4647

4748
if sr_uuid is None:
4849
return vdis

lib/snapshot.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44

55
class Snapshot(BaseVM):
66
def _disk_list(self):
7-
return self.host.xe('snapshot-disk-list', {'uuid': self.uuid}, minimal=True)
7+
return self.host.xe('snapshot-disk-list', {'uuid': self.uuid, 'vbd-params': ''},
8+
minimal=True)
89

910
def destroy(self, verify=False):
1011
logging.info("Delete snapshot " + self.uuid)

lib/vm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def unpause(self):
159159
self.host.xe('vm-unpause', {'uuid': self.uuid})
160160

161161
def _disk_list(self):
162-
return self.host.xe('vm-disk-list', {'uuid': self.uuid}, minimal=True)
162+
return self.host.xe('vm-disk-list', {'uuid': self.uuid, 'vbd-params': ''}, minimal=True)
163163

164164
def _destroy(self):
165165
self.host.xe('vm-destroy', {'uuid': self.uuid})

0 commit comments

Comments
 (0)