Added test_linstor_sr_expand_host to validate the expansion of Linstor SR by integrating a new host into the storage pool.

The test:
- Ensures the new host has available disks and installs required Linstor packages.
- Configures LVM and integrates it into Linstor SR pool.
- Expands SR capacity and validates the increase.
- Handles cleanup by removing the node.

Signed-off-by: Rushikesh Jadhav <[email protected]>

Author: rushikeshjadhav

tests/storage/linstor/test_linstor_sr.py

@@ -109,6 +109,68 @@ def test_linstor_sr_expand_disk(self, linstor_sr, provisioning_type, storage_poo
             f"Expected SR size to increase but got old size: {sr_size}, new size: {new_sr_size}"
         logging.info("SR expansion completed")
 
+    @pytest.mark.small_vm
+    def test_linstor_sr_expand_host(self, linstor_sr, vm_with_reboot_check, prepare_linstor_packages,
+                                    join_host_to_pool, setup_lvm_on_host, host, hostB1, storage_pool_name,
+                                    provisioning_type):
+        """
+        This test validates expansion of a LINSTOR SR by dynamically adding a new host with local storage to the pool.
+        A VM is started on the SR before expansion begins to ensure the SR is in active use during the process.
+
+        It performs the following steps:
+        - Installs LINSTOR packages on the new host (if missing).
+        - Detects and prepares raw disks using LVM commands.
+        - Joins the host (hostB1) to the existing pool and registers it with LINSTOR as a node.
+        - Creates a new LINSTOR storage pool on the added host (LVM or LVM-thin, based on provisioning type).
+        - Confirms SR expansion by verifying increased physical size.
+        - Ensures SR functionality by rebooting the VM running on the SR.
+
+        Finally, the test cleans up by deleting the LINSTOR node, ejecting the host from the pool,
+        and removing packages and LVM metadata.
+        """
+        sr = linstor_sr
+        sr_size = sr.pool.master.xe('sr-param-get', {'uuid': sr.uuid, 'param-name': 'physical-size'})
+        resized = False
+
+        # TODO: This section could be moved into a separate fixture for modularity.
+        # However, capturing the SR size before expansion is critical to the test logic,
+        # so it's intentionally kept inline to preserve control over the measurement point.
+
+        sr_group_name = "xcp-sr-" + storage_pool_name.replace("/", "_")
+        hostname = hostB1.xe('host-param-get', {'uuid': hostB1.uuid, 'param-name': 'name-label'})
+        controller_option = "--controllers=" + ",".join([m.hostname_or_ip for m in host.pool.hosts])
+
+        logging.info("Current list of linstor nodes:")
+        logging.info(host.ssh_with_result(["linstor", controller_option, "node", "list"]).stdout)
+
+        logging.info("Creating linstor node")
+        host.ssh(["linstor", controller_option, "node", "create", "--node-type", "combined",
+                 "--communication-type", "plain", hostname, hostB1.hostname_or_ip])
+        hostB1.ssh(['systemctl', 'restart', 'linstor-satellite.service'])
+        time.sleep(45)
+
+        logging.info("New list of linstor nodes:")
+        logging.info(host.ssh_with_result(["linstor", controller_option, "node", "list"]).stdout)
+        logging.info("Expanding with linstor node")
+
+        if provisioning_type == "thin":
+            hostB1.ssh(['lvcreate', '-l', '+100%FREE', '-T', storage_pool_name])
+            host.ssh(["linstor", controller_option, "storage-pool", "create", "lvmthin",
+                     hostname, sr_group_name, storage_pool_name])
+        else:
+            host.ssh(["linstor", controller_option, "storage-pool", "create", "lvm",
+                     hostname, sr_group_name, storage_pool_name])
+
+        sr.scan()
+        resized = True
+        new_sr_size = sr.pool.master.xe('sr-param-get', {'uuid': sr.uuid, 'param-name': 'physical-size'})
+        assert int(new_sr_size) > int(sr_size) and resized is True, \
+            f"Expected SR size to increase but got old size: {sr_size}, new size: {new_sr_size}"
+        logging.info("SR expansion completed from size %s to %s", sr_size, new_sr_size)
+
+        # Cleanup
+        host.ssh(["linstor", controller_option, "node", "delete", hostname])
+
     # *** tests with reboots (longer tests).
 
     @pytest.mark.reboot