ssh: log command before launching it

ydirson · ydirson · commit da3bf330ddf8 · 2025-03-25T16:46:53.000+01:00
... helps debugging quite a bit.

Signed-off-by: Yann Dirson &lt;yann.dirson@vates.tech&gt;
diff --git a/lib/commands.py b/lib/commands.py
@@ -95,13 +95,13 @@ def _ssh(hostname_or_ip, cmd, check, simple_output, suppress_fingerprint_warning
             check=False
         )
 
+    logging.debug(f"[{hostname_or_ip}] {command}")
     process = subprocess.Popen(
         ssh_cmd,
         shell=True,
         stdout=subprocess.PIPE,
         stderr=subprocess.STDOUT
     )
-    logging.debug(f"[{hostname_or_ip}] {command}")
     if windows_background:
         return True, process
 

Original file line number	Diff line number	Diff line change
`@@ -95,13 +95,13 @@ def _ssh(hostname_or_ip, cmd, check, simple_output, suppress_fingerprint_warning`
`95`	`95`	`check=False`
`96`	`96`	`)`
`97`	`97`
	`98`	`+ logging.debug(f"[{hostname_or_ip}] {command}")`
`98`	`99`	`process = subprocess.Popen(`
`99`	`100`	`ssh_cmd,`
`100`	`101`	`shell=True,`
`101`	`102`	`stdout=subprocess.PIPE,`
`102`	`103`	`stderr=subprocess.STDOUT`
`103`	`104`	`)`
`104`		`- logging.debug(f"[{hostname_or_ip}] {command}")`
`105`	`105`	`if windows_background:`
`106`	`106`	`return True, process`
`107`	`107`