Temporary fist tests for resize

Author: Nambrok

conftest.py

@@ -742,7 +742,7 @@ def nfs_iso_sr(host, nfs_iso_device_config):
     # teardown
     sr.forget()
 
-@pytest.fixture(scope='module')
+@pytest.fixture(scope='function')
 def exit_on_fistpoint(host):
     from lib.fistpoint import FistPoint
     logging.info(">> Enabling exit on fistpoint")

tests/storage/ext/test_ext_sr.py

@@ -1,5 +1,8 @@
 import pytest
+import logging
 from lib.common import wait_for, vm_image
+from lib.fistpoint import FistPoint
+from lib.vdi import VDI
 from tests.storage import try_to_create_sr_with_missing_device, vdi_is_open
 
 # Requirements:
@@ -54,6 +57,47 @@ def test_snapshot(self, vm_on_ext_sr):
 
     # *** tests with reboots (longer tests).
 
+    @pytest.mark.small_vm
+    @pytest.mark.big_vm
+    def test_blktap_activate_failure(self, vm_on_ext_sr):
+        from lib.fistpoint import FistPoint
+        vm = vm_on_ext_sr
+        with FistPoint(vm.host, "blktap_activate_inject_failure"):
+            try:
+                vm.start()
+                vm.shutdown(force=True)
+            except Exception as e:
+                logging.info(f"Expected failure {e}")
+
+    @pytest.mark.small_vm
+    @pytest.mark.big_vm
+    def test_resize(self, vm_on_ext_sr):
+        vm = vm_on_ext_sr
+        vdi = VDI(vm.vdi_uuids()[0], host=vm.host)
+        old_size = vdi.size()
+        new_size = old_size + (1 * 1024 * 1024 * 1024) # Adding a 1GiB to size
+
+        vdi.resize(new_size)
+
+        assert vdi.size() == new_size
+
+    @pytest.mark.small_vm
+    @pytest.mark.big_vm
+    def test_failing_resize(self, host, ext_sr, vm_on_ext_sr, exit_on_fistpoint):
+        vm = vm_on_ext_sr
+        vdi = VDI(vm.vdi_uuids()[0], host=vm.host)
+        old_size = vdi.size()
+        new_size = old_size + (1 * 1024 * 1024 * 1024) # Adding a 1GiB to size
+
+        with FistPoint(vm.host, "LVHDRT_inflate_after_setSize"):
+            try:
+                vdi.resize(new_size)
+            except:
+                logging.info(f"Launching SR scan for {ext_sr} after failure")
+                host.xe("sr-scan", {"uuid": ext_sr})
+
+        assert vdi.size() == new_size
+
     @pytest.mark.reboot
     @pytest.mark.small_vm
     def test_reboot(self, host, ext_sr, vm_on_ext_sr):

tests/storage/lvm/test_lvm_sr.py

@@ -1,5 +1,9 @@
 import pytest
+import logging
+from lib.commands import SSHCommandFailed
 from lib.common import wait_for, vm_image
+from lib.vdi import VDI
+from lib.fistpoint import FistPoint
 from tests.storage import try_to_create_sr_with_missing_device, vdi_is_open
 
 # Requirements:
@@ -52,6 +56,66 @@ def test_snapshot(self, vm_on_lvm_sr):
         finally:
             vm.shutdown(verify=True)
 
+    @pytest.mark.small_vm
+    @pytest.mark.big_vm
+    def test_failing_resize_on_inflate_after_setSize(self, host, lvm_sr, vm_on_lvm_sr, exit_on_fistpoint):
+        vm = vm_on_lvm_sr
+        lvinflate = ""
+        need_rescan = False
+        vdi = VDI(vm.vdi_uuids()[0], host=vm.host)
+        new_size = vdi.size() + (1 * 1024 * 1024 * 1024) # Adding a 1GiB to size
+
+        with FistPoint(vm.host, "LVHDRT_inflate_after_setSize"):
+            try:
+                vdi.resize(new_size)
+            except SSHCommandFailed as e:
+                logging.info(e)
+                need_rescan = True
+
+        assert need_rescan, "Resize did not make an error"
+        lvlist = host.lvs(f"VG_XenStorage-{lvm_sr.uuid}")
+        for lv in lvlist:
+            if lv.startswith("inflate_"):
+                logging.info(f"Found inflate journal following error: {lv}")
+                lvinflate = lv
+
+        logging.info(f"Launching SR scan for {lvm_sr.uuid} to resolve failure")
+        try:
+            host.xe("sr-scan", {"uuid": lvm_sr.uuid})
+        except SSHCommandFailed as e:
+            assert False, f"Failing to scan following a inflate error {e}"
+        assert not lvinflate in host.lvs(f"VG_XenStorage-{lvm_sr.uuid}"), "Inflate journal still exist following the scan"
+
+    @pytest.mark.small_vm
+    @pytest.mark.big_vm
+    def test_failing_resize_on_inflate_after_setSizePhys(self, host, lvm_sr, vm_on_lvm_sr, exit_on_fistpoint):
+        vm = vm_on_lvm_sr
+        lvinflate = ""
+        need_rescan = False
+        vdi = VDI(vm.vdi_uuids()[0], host=vm.host)
+        new_size = vdi.size() + (1 * 1024 * 1024 * 1024) # Adding a 1GiB to size
+
+        with FistPoint(vm.host, "LVHDRT_inflate_after_setSizePhys"):
+            try:
+                vdi.resize(new_size)
+            except SSHCommandFailed as e:
+                logging.info(e)
+                need_rescan = True
+
+        assert need_rescan, "Resize did not make an error"
+        lvlist = host.lvs(f"VG_XenStorage-{lvm_sr.uuid}")
+        for lv in lvlist:
+            if lv.startswith("inflate_"):
+                logging.info(f"Found inflate journal following error: {lv}")
+                lvinflate = lv
+
+        logging.info(f"Launching SR scan for {lvm_sr.uuid} to resolve failure")
+        try:
+            host.xe("sr-scan", {"uuid": lvm_sr.uuid})
+        except SSHCommandFailed as e:
+            assert False, f"Failing to scan following a inflate error {e}"
+        assert not lvinflate in host.lvs(f"VG_XenStorage-{lvm_sr.uuid}"), "Inflate journal still exist following the scan"
+
     # *** tests with reboots (longer tests).
 
     @pytest.mark.reboot