WIP install 7/n: use iso-remaster to plug an answerfile

FIXME:
- hardcoded config values
- hardcoded HTTP answerfile, not generated

Author: ydirson

data.py-dist

@@ -26,12 +26,30 @@ PXE_CONFIG_SERVER = 'pxe'
 # Default VM images location
 DEF_VM_URL = 'http://pxe/images/'
 
+# Default shared ISO SR
+ISOSR_SRV = "nfs-server"
+ISOSR_PATH = "/srv/iso-sr"
+
+# Tools
+TOOLS = {
+#    "iso-remaster": "/home/user/src/xcpng/xcp/scripts/iso-remaster/iso-remaster.sh",
+}
+
 # Values can be either full URLs or only partial URLs that will be automatically appended to DEF_VM_URL
 VM_IMAGES = {
     'mini-linux-x86_64-bios': 'alpine-minimal-3.12.0.xva',
     'mini-linux-x86_64-uefi': 'alpine-uefi-minimal-3.12.0.xva'
 }
 
+# FIXME: use URLs and an optional cache?
+ISO_IMAGES = {
+#    'xcpng-8.2.0': "/home/user/iso/xcp-ng-8.2.0.iso",
+#    'xcpng-8.2.1': "/home/user/iso/xcp-ng-8.2.1.iso",
+#    'xcpng-8.2.1-2023': "/home/user/iso/xcp-ng-8.2.1-20231130.iso",
+#    'xcpng-8.3-beta2': "/home/user/iso/xcp-ng-8.3.0-beta2.iso",
+#    'xcpng-8.3-beta2-net': "/home/user/iso/xcp-ng-8.3.0-beta2-netinstall.iso",
+}
+
 # In some cases, we may prefer to favour a local SR to store test VM disks,
 # to avoid latency or unstabilities related to network or shared file servers.
 # However it's not good practice to make a local SR the default SR for a pool of several hosts.

pytest.ini

@@ -22,6 +22,9 @@ markers =
     # * VM-related markers to give parameters to fixtures
     vm_definitions: dicts of VM defs for create_vms fixture.
 
+    # * installation-related markers to customize installer run
+    installer_iso: key of data.ISO_IMAGES identifying an installer ISO
+
     # * Test targets related to VMs
     small_vm: tests that it is enough to run just once, using the smallest possible VM.
     big_vm: tests that it would be good to run with a big VM.

tests/install/conftest.py

@@ -0,0 +1,80 @@
+import logging
+import os
+import pytest
+import tempfile
+
+from lib.commands import local_cmd, scp, ssh
+
+@pytest.fixture(scope='function')
+def iso_remaster(request, answerfile):
+    marker = request.node.get_closest_marker("installer_iso")
+    assert marker is not None, "iso_remaster fixture requires 'installer_iso' marker"
+    iso_key = marker.args[0]
+    ANSWERFILE_URL = "http://pxe/configs/custom/ydi/install-8.2-uefi-iso-ext.xml" # FIXME
+
+    from data import ISO_IMAGES, ISOSR_SRV, ISOSR_PATH, TOOLS
+    assert "iso-remaster" in TOOLS
+    iso_remaster = TOOLS["iso-remaster"]
+    assert os.access(iso_remaster, os.X_OK)
+
+    assert iso_key in ISO_IMAGES, f"ISO_IMAGES does not have a value for {iso_key}"
+    SOURCE_ISO = ISO_IMAGES[iso_key]
+
+    with tempfile.TemporaryDirectory() as isotmp:
+        remastered_iso = os.path.join(isotmp, "image.iso")
+        iso_patcher_script = os.path.join(isotmp, "iso-patcher")
+
+        logging.info("Remastering %s to %s", SOURCE_ISO, remastered_iso)
+
+        # generate install.img-patcher script
+        with open(img_patcher_script, "xt") as patcher_fd:
+            print(f"""#!/bin/bash
+set -ex
+INSTALLIMG="$1"
+
+curl {ANSWERFILE_URL} -o "$INSTALLIMG/root/answerfile.xml"
+""",
+                  file=patcher_fd)
+            os.chmod(patcher_fd.fileno(), 0o755)
+
+        # generate iso-patcher script
+        with open(iso_patcher_script, "xt") as patcher_fd:
+            passwd = "passw0rd" # FIXME hash
+            print(f"""#!/bin/bash
+set -ex
+ISODIR="$1"
+SED_COMMANDS=(-e "s@/vmlinuz@/vmlinuz sshpassword={passwd} atexit=shell@")
+SED_COMMANDS+=(-e "s@/vmlinuz@/vmlinuz install answerfile=file:///root/answerfile.xml network_device=all@")
+
+sed -i "${{SED_COMMANDS[@]}}" \
+    "$ISODIR"/*/*/grub*.cfg \
+    "$ISODIR"/boot/isolinux/isolinux.cfg
+""",
+                  file=patcher_fd)
+            os.chmod(patcher_fd.fileno(), 0o755)
+
+        # do remaster
+        local_cmd([iso_remaster,
+                   "--iso-patcher", iso_patcher_script,
+                   SOURCE_ISO, remastered_iso
+                   ])
+
+        # unique filename on server, has to work on FreeBSD-based NAS
+        # too, and even v14 has no tool allowing mktemp suffixes
+        remote_iso = ssh(ISOSR_SRV,
+                         ["python3", "-c",
+                          '"import os, tempfile; '
+                          f"f = tempfile.mkstemp(suffix='.iso', dir='{ISOSR_PATH}')[1];"
+                          "os.chmod(f, 0o644);"
+                          'print(f);"'
+                          ])
+        logging.info("Uploading to ISO-SR server remastered %s as %s",
+                     remastered_iso, os.path.basename(remote_iso))
+        scp(ISOSR_SRV, remastered_iso, remote_iso)
+        # FIXME: is sr-scan ever needed?
+
+    try:
+        yield os.path.basename(remote_iso)
+    finally:
+        logging.info("Removing %s from ISO-SR server", os.path.basename(remote_iso))
+        ssh(ISOSR_SRV, ["rm", remote_iso])

tests/install/test.py

@@ -18,10 +18,11 @@ class TestNested:
              vdis=[dict(name="vm 1 system disk", size="100GiB", device="xvda", userdevice="0")],
              vifs=[dict(index=0, network_uuid="eabc1038-e40f-2ae5-0781-a3adbec1cae8")], # FIXME
              ))
-    def test_nested_821_uefi(self, create_vms):
+    @pytest.mark.installer_iso("xcpng-8.2.1-2023")
+    def test_install_821_uefi(self, iso_remaster, create_vms):
         assert len(create_vms) == 1
         host_vm = create_vms[0]
         # FIXME should be part of vm def
         host_vm.create_cd_vbd(device="xvdd", userdevice="3")
 
-        host_vm.insert_cd("xcp-ng-8.2.1-20231130.iso")
+        host_vm.insert_cd(iso_remaster)