Skip to content

Commit f82aa92

Browse files
committed
Use two new sections for ruff: typing and testing
- Everything related to the `typing` module is grouped in the second import section. Typing is just there for verification purposes, it's not a logic module like a local or system module that is used in functions or algorithms. - And all `pytest` imports are added in a third section just after `typing`. - `future` imports are in the first section to avoid this error during checks: """ SyntaxError: from __future__ imports must occur at the beginning of the file """ Signed-off-by: Ronan Abhamon <[email protected]>
1 parent ca949c4 commit f82aa92

File tree

86 files changed

+192
-156
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

86 files changed

+192
-156
lines changed

conftest.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1+
from typing import Dict
2+
3+
import pytest
4+
15
import itertools
26
import logging
37
import os
48
import tempfile
5-
from typing import Dict
69

710
import git
8-
import pytest
911
from packaging import version
1012

1113
import lib.config as global_config

lib/basevm.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import logging
21
from typing import TYPE_CHECKING, Any, Literal, Optional, overload
32

3+
import logging
4+
45
if TYPE_CHECKING:
56
import lib.host
67

lib/commands.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
from typing import List, Literal, Union, overload
2+
13
import base64
24
import logging
35
import shlex
46
import subprocess
5-
from typing import List, Literal, Union, overload
67

78
import lib.config as config
89
from lib.netutil import wrap_ip

lib/common.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
from typing import TYPE_CHECKING, Callable, Dict, Literal, Optional, TypeVar, Union, cast, overload
2+
3+
import pytest
4+
15
import getpass
26
import inspect
37
import itertools
@@ -7,10 +11,8 @@
711
import time
812
import traceback
913
from enum import Enum
10-
from typing import TYPE_CHECKING, Callable, Dict, Literal, Optional, TypeVar, Union, cast, overload
1114
from uuid import UUID
1215

13-
import pytest
1416
import requests
1517

1618
import lib.commands as commands

lib/host.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
from __future__ import annotations
22

3+
from typing import TYPE_CHECKING, Dict, List, Literal, Optional, Union, overload
4+
35
import logging
46
import os
57
import shlex
68
import tempfile
79
import uuid
8-
from typing import TYPE_CHECKING, Dict, List, Literal, Optional, Union, overload
910

1011
from packaging import version
1112

lib/pool.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
from typing import Any, Dict, Optional
2+
13
import logging
24
import os
35
import traceback
4-
from typing import Any, Dict, Optional
56

67
from packaging import version
78

lib/typing.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import sys
21
from typing import TypedDict
32

3+
import sys
4+
45
if sys.version_info >= (3, 11):
56
from typing import NotRequired
67
else:

lib/vdi.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import logging
21
from typing import TYPE_CHECKING, Literal, Optional, overload
32

3+
import logging
4+
45
from lib.common import _param_add, _param_clear, _param_get, _param_remove, _param_set, strtobool
56

67
if TYPE_CHECKING:

lib/vm.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
from __future__ import annotations
22

3+
from typing import TYPE_CHECKING, List, Literal, Optional, Union, overload
4+
35
import logging
46
import os
57
import tempfile
6-
from typing import TYPE_CHECKING, List, Literal, Optional, Union, overload
78

89
import lib.commands as commands
910
import lib.efi as efi

lib/xo.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
from typing import Any, Dict, Literal, Union, overload
2+
13
import json
24
import subprocess
3-
from typing import Any, Dict, Literal, Union, overload
45

56
@overload
67
def xo_cli(action: str, args: Dict[str, str] = {}, *, check: bool = True, simple_output: Literal[True] = True,

0 commit comments

Comments
 (0)