deprecate argument xy_var_names

Author: TonioF

xcube/core/gridmapping/base.py

@@ -648,6 +648,7 @@ def from_dataset(cls,
         :param crs: Optional spatial coordinate reference system.
         :param xy_var_names: Optional tuple of the x- and
             y-coordinate variables in *dataset*.
+            Deprecated since xcube 0.10.1.
         :param tile_size: Optional tile size
         :param prefer_is_regular: Whether to prefer a regular
             grid mapping if multiple found. Default is True.

xcube/core/gridmapping/dataset.py

@@ -20,6 +20,7 @@
 # SOFTWARE.
 
 from typing import Optional, Union, Tuple
+import warnings
 
 import pyproj
 import xarray as xr
@@ -53,13 +54,10 @@ def new_grid_mapping_from_dataset(
         prefer_crs = _normalize_crs(prefer_crs)
     else:
         prefer_crs = crs
-    if xy_var_names is not None:
-        x_var_name, y_var_name = xy_var_names
-        if x_var_name not in dataset or y_var_name not in dataset:
-            raise ValueError(f'coordinate variables "{x_var_name}" '
-                             f'or "{y_var_name}" not found in dataset')
-        # TODO: create new instance using named coordinate variables
-        raise NotImplementedError('xy_var_names not yet supported')
+    if xy_var_names:
+        warnings.warn('Argument "xy_var_names" is deprecated since '
+                      'xcube 0.10.1 and will be ignored.',
+                      category=DeprecationWarning)
 
     grid_mapping_proxies = get_dataset_grid_mapping_proxies(
         dataset,