fix(download): pause & resume not working

Author: xdagiz

README.md

@@ -33,7 +33,8 @@ https://github.com/user-attachments/assets/4e3f98c7-554f-4b9e-adac-52511ae69f32
 
 **Requirements:**
 
-- Installation: https://github.com/yt-dlp/yt-dlp#installation
+- **yt-dlp**: Core video downloader
+  - Installation: https://github.com/yt-dlp/yt-dlp#installation
 - **ffmpeg** - Required for full features
   - Installation: https://ffmpeg.org/download.html
 

internal/utils/download_pause_resume_test.go

@@ -0,0 +1,66 @@
+//go:build !windows
+
+package utils
+
+import (
+	"os/exec"
+	"testing"
+
+	"github.com/xdagiz/xytz/internal/types"
+)
+
+func TestPauseResumeDownload_NoProcessNoMessage(t *testing.T) {
+	dm := NewDownloadManager()
+
+	pauseCmd := PauseDownload(dm)
+	if pauseCmd == nil {
+		t.Fatalf("PauseDownload returned nil command")
+	}
+	if msg := pauseCmd(); msg != nil {
+		t.Fatalf("pause msg = %T, want nil when no process is attached", msg)
+	}
+	if dm.IsPaused() {
+		t.Fatalf("manager paused = true, want false")
+	}
+
+	resumeCmd := ResumeDownload(dm)
+	if resumeCmd == nil {
+		t.Fatalf("ResumeDownload returned nil command")
+	}
+	if msg := resumeCmd(); msg != nil {
+		t.Fatalf("resume msg = %T, want nil when no process is attached", msg)
+	}
+}
+
+func TestPauseResumeDownload_WithRunningProcessSendsMessages(t *testing.T) {
+	dm := NewDownloadManager()
+
+	cmd := exec.Command("sh", "-c", "sleep 5")
+	if err := cmd.Start(); err != nil {
+		t.Fatalf("failed to start helper process: %v", err)
+	}
+	defer func() {
+		_ = cmd.Process.Kill()
+		_, _ = cmd.Process.Wait()
+	}()
+
+	dm.SetCmd(cmd)
+
+	pauseCmd := PauseDownload(dm)
+	pauseMsg := pauseCmd()
+	if _, ok := pauseMsg.(types.PauseDownloadMsg); !ok {
+		t.Fatalf("pause msg = %T, want types.PauseDownloadMsg", pauseMsg)
+	}
+	if !dm.IsPaused() {
+		t.Fatalf("manager paused = false, want true after pause")
+	}
+
+	resumeCmd := ResumeDownload(dm)
+	resumeMsg := resumeCmd()
+	if _, ok := resumeMsg.(types.ResumeDownloadMsg); !ok {
+		t.Fatalf("resume msg = %T, want types.ResumeDownloadMsg", resumeMsg)
+	}
+	if dm.IsPaused() {
+		t.Fatalf("manager paused = true, want false after resume")
+	}
+}

internal/utils/download_unix.go

@@ -14,27 +14,33 @@ import (
 func PauseDownload(dm *DownloadManager) tea.Cmd {
 	return tea.Cmd(func() tea.Msg {
 		cmd := dm.GetCmd()
-		if cmd != nil && cmd.Process != nil && !dm.IsPaused() {
-			dm.SetPaused(true)
-			if err := cmd.Process.Signal(syscall.SIGSTOP); err != nil {
-				log.Printf("Failed to pause download: %v", err)
-			}
+		if cmd == nil || cmd.Process == nil || dm.IsPaused() {
+			return nil
 		}
 
+		if err := cmd.Process.Signal(syscall.SIGSTOP); err != nil {
+			log.Printf("Failed to pause download: %v", err)
+			return nil
+		}
+
+		dm.SetPaused(true)
 		return types.PauseDownloadMsg{}
 	})
 }
 
 func ResumeDownload(dm *DownloadManager) tea.Cmd {
 	return tea.Cmd(func() tea.Msg {
 		cmd := dm.GetCmd()
-		if cmd != nil && cmd.Process != nil && dm.IsPaused() {
-			dm.SetPaused(false)
-			if err := cmd.Process.Signal(syscall.SIGCONT); err != nil {
-				log.Printf("Failed to resume download: %v", err)
-			}
+		if cmd == nil || cmd.Process == nil || !dm.IsPaused() {
+			return nil
+		}
+
+		if err := cmd.Process.Signal(syscall.SIGCONT); err != nil {
+			log.Printf("Failed to resume download: %v", err)
+			return nil
 		}
 
+		dm.SetPaused(false)
 		return types.ResumeDownloadMsg{}
 	})
 }

internal/utils/download_windows.go

@@ -17,7 +17,7 @@ func PauseDownload(dm *DownloadManager) tea.Cmd {
 			log.Print("pause not supported on windows")
 		}
 
-		return types.PauseDownloadMsg{}
+		return nil
 	})
 }
 
@@ -28,6 +28,6 @@ func ResumeDownload(dm *DownloadManager) tea.Cmd {
 			log.Print("resume not supported on windows")
 		}
 
-		return types.ResumeDownloadMsg{}
+		return nil
 	})
 }