Revert watch property get to eval with eval_cache.

Author: zobo

src/phpDebug.ts

@@ -1475,7 +1475,7 @@ class PhpDebugSession extends vscode.DebugSession {
                 if (res.property) {
                     result = res.property
                 }
-            } else if (args.context === 'repl') {
+            } else if (args.context === 'repl' || args.context === 'watch') {
                 const uuid = randomUUID()
                 await connection.sendEvalCommand(`$GLOBALS['eval_cache']['${uuid}']=${args.expression}`)
                 const ctx = await stackFrame.getContexts() // TODO CACHE THIS
@@ -1489,30 +1489,6 @@ class PhpDebugSession extends vscode.DebugSession {
                 response.body = { result: await varExportProperty(res.property), variablesReference: 0 }
                 this.sendResponse(response)
                 return
-            } else if (args.context === 'watch') {
-                // try to translate static variable to special Xdebug format
-                if (args.expression.startsWith('self::$')) {
-                    args.expression = '$this::' + args.expression.substring(7)
-                }
-                // if we suspect a function call
-                if (!args.expression.startsWith('$') || args.expression.includes('(')) {
-                    if (stackFrame.level !== 0) {
-                        throw new Error('Cannot evaluate function calls when not on top of the stack')
-                    }
-                    const uuid = randomUUID()
-                    await connection.sendEvalCommand(`$GLOBALS['eval_cache']['${uuid}']=${args.expression}`)
-                    const ctx = await stackFrame.getContexts() // TODO CACHE THIS
-                    const res = await connection.sendPropertyGetNameCommand(`$eval_cache['${uuid}']`, ctx[1])
-                    if (res.property) {
-                        result = res.property
-                    }
-                } else {
-                    const ctx = await stackFrame.getContexts() // TODO CACHE THIS
-                    const res = await connection.sendPropertyGetNameCommand(args.expression, ctx[0])
-                    if (res.property) {
-                        result = res.property
-                    }
-                }
             } else {
                 const res = await connection.sendEvalCommand(args.expression)
                 if (res.result) {