Skip to content

Commit 0d2422a

Browse files
committed
fix: Do not display error dialog on failed eval (#561)
* fix: Eval errors should not be returned with sendErrorResponse to prevent showing the error dialog.
1 parent 602a5f7 commit 0d2422a

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
1010

1111
- Support for terminateDebuggee option letting the user choose to keep the debugee running. Press Alt when hovering over stop action.
1212
- Handle breakpoints in a async manner.
13+
14+
### Changed
15+
16+
- Do not display error dialog on failed eval

src/phpDebug.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,9 @@ class PhpDebugSession extends vscode.DebugSession {
961961
}
962962
this.sendResponse(response)
963963
} catch (error) {
964-
this.sendErrorResponse(response, error)
964+
response.message = error.message
965+
response.success = false
966+
this.sendResponse(response)
965967
}
966968
}
967969
}

0 commit comments

Comments
 (0)