Skip to content

Commit 6b25353

Browse files
authored
fix: filter extended property children by tag name (#752)
1 parent 6a5a4b9 commit 6b25353

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## [1.24.1]
8+
9+
- Fix for extended root property #751
10+
711
## [1.24.0]
812

913
- F10/F11 start debugging with stop on entry.

src/xdebugConnection.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ export class Property extends BaseProperty {
571571
}
572572
this.context = context
573573
if (this.hasChildren) {
574-
this.children = Array.from(propertyNode.childNodes).map(
574+
this.children = Array.from((<Element>propertyNode).getElementsByTagName('property')).map(
575575
(propertyNode: Element) => new Property(propertyNode, context)
576576
)
577577
}
@@ -644,9 +644,9 @@ export class PropertyGetResponse extends Response {
644644
*/
645645
constructor(document: XMLDocument, context: Context) {
646646
super(document, context.stackFrame.connection)
647-
this.children = Array.from(document.documentElement.firstChild!.childNodes).map(
648-
(propertyNode: Element) => new Property(propertyNode, context)
649-
)
647+
this.children = Array.from(
648+
(<Element>document.documentElement.firstChild!).getElementsByTagName('property')
649+
).map((propertyNode: Element) => new Property(propertyNode, context))
650650
}
651651
}
652652

0 commit comments

Comments
 (0)