fix: Auto configure runtimeExecutable when only runtimeArgs are used (built-in web server). (#683)

zobo · web-flow · commit 76f8c57bdcfe · 2021-10-30T23:43:51.000+02:00
[skip ci]
diff --git a/src/extension.ts b/src/extension.ts
@@ -28,7 +28,10 @@ export function activate(context: vscode.ExtensionContext) {
                         // debugConfiguration.stopOnEntry = true
                     }
                 }
-                if (debugConfiguration.program && !debugConfiguration.runtimeExecutable) {
+                if (
+                    (debugConfiguration.program || debugConfiguration.runtimeArgs) &&
+                    !debugConfiguration.runtimeExecutable
+                ) {
                     // See if we have runtimeExecutable configured
                     const conf = vscode.workspace.getConfiguration('php')
                     const executablePath =

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,10 @@ export function activate(context: vscode.ExtensionContext) {`
`28`	`28`	`// debugConfiguration.stopOnEntry = true`
`29`	`29`	`}`
`30`	`30`	`}`
`31`		`- if (debugConfiguration.program && !debugConfiguration.runtimeExecutable) {`
	`31`	`+ if (`
	`32`	`+ (debugConfiguration.program \|\| debugConfiguration.runtimeArgs) &&`
	`33`	`+ !debugConfiguration.runtimeExecutable`
	`34`	`+ ) {`
`32`	`35`	`// See if we have runtimeExecutable configured`
`33`	`36`	`const conf = vscode.workspace.getConfiguration('php')`
`34`	`37`	`const executablePath =`