feat: Process facets to property presentation hints (#655)

* Process facets on dbgp property. Translate some facets to DAP property presentation hint visibility, attributes...

* Process the virtual facet.

[skip actions]

Author: zobo

src/phpDebug.ts

@@ -861,11 +861,33 @@ class PhpDebugSession extends vscode.DebugSession {
                     } else {
                         evaluateName = property.name
                     }
+                    let presentationHint: VSCodeDebugProtocol.VariablePresentationHint = {}
+                    if (property.facets?.length) {
+                        if (property.facets.includes('public')) {
+                            presentationHint.visibility = 'public'
+                        } else if (property.facets.includes('private')) {
+                            presentationHint.visibility = 'private'
+                        } else if (property.facets.includes('protected')) {
+                            presentationHint.visibility = 'protected'
+                        }
+                        if (property.facets.includes('readonly')) {
+                            presentationHint.attributes = presentationHint.attributes || []
+                            presentationHint.attributes.push('readOnly')
+                        }
+                        if (property.facets.includes('static')) {
+                            presentationHint.attributes = presentationHint.attributes || []
+                            presentationHint.attributes.push('static')
+                        }
+                        if (property.facets.includes('virtual')) {
+                            presentationHint.kind = 'virtual'
+                        }
+                    }
                     const variable: VSCodeDebugProtocol.Variable = {
                         name: property.name,
                         value: displayValue,
                         type: property.type,
                         variablesReference,
+                        presentationHint,
                         evaluateName,
                     }
                     return variable

src/xdebugConnection.ts

@@ -482,6 +482,8 @@ export abstract class BaseProperty {
     value: string
     /** children that were already included in the response */
     children: BaseProperty[]
+    /** provided facets */
+    facets: ('public' | 'private' | 'protected' | 'static' | 'readonly' | string)[]
 
     constructor(propertyNode: Element) {
         if (propertyNode.hasAttribute('name')) {
@@ -495,6 +497,9 @@ export abstract class BaseProperty {
         } else if (propertyNode.getElementsByTagName('classname').length > 0) {
             this.class = decodeTag(propertyNode, 'classname')
         }
+        if (propertyNode.hasAttribute('facet')) {
+            this.facets = propertyNode.getAttribute('facet')!.split(' ')
+        }
         this.hasChildren = !!parseInt(propertyNode.getAttribute('children')!)
         if (this.hasChildren) {
             this.numberOfChildren = parseInt(propertyNode.getAttribute('numchildren')!)