Fix/Suppress PMD

Related: #14

Author: AB-xdev

bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/exception/TaxNumberException.java

@@ -23,6 +23,6 @@ public class TaxNumberException extends ConfigurationException
 {
 	public TaxNumberException(final String taxNumber)
 	{
-		super("The taxnumber (Steueridentifikationsnummer) is not valid!");
+		super("The taxnumber (Steueridentifikationsnummer) '" + taxNumber + "' is not valid!");
 	}
 }

bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/util/WebClientUtil.java

@@ -24,8 +24,6 @@
 import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 import org.w3c.dom.Node;
@@ -41,7 +39,6 @@
  */
 public final class WebClientUtil
 {
-	private static final Logger LOGGER = LoggerFactory.getLogger(WebClientUtil.class);
 	public static final String TAG_NAME_DATENTRANSFERNUMMER = "Datentransfernummer";
 
 	private WebClientUtil()

bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/webclient/WebClient.java

@@ -141,8 +141,6 @@ public BzstDipSingleTransferResult requestTransferResult(final String dataTransf
 			)
 		)
 		{
-			final String text = new String(inputStream.readAllBytes(), StandardCharsets.UTF_8);
-			
 			// TODO: Check text
 			return new BzstDipSingleTransferResult(dataTransferNumber, 2);
 

bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/xmldocument/ReportableSellerCreator.java

@@ -338,7 +338,7 @@ private static OrganisationPartyType createOrganisationPartyType(
 	 */
 	public static boolean isNULLAsString(final String checkNULLString)
 	{
-		return checkNULLString.equals(NULL_STRING);
+		return NULL_STRING.equals(checkNULLString);
 	}
 
 	private static OrganisationINType createIN(final String in)

bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/xmldocument/XMLDocumentBodyCreator.java

@@ -133,6 +133,7 @@ private Object createData(
 		return dataType;
 	}
 
+	@SuppressWarnings("PMD.UnusedFormalParameter") // TODO Needs to be resolved!
 	private Object createData(
 		final PaymentDataBodyType paymentDataBodyType) throws DatatypeConfigurationException
 	{

bzst-dip-java-client/src/test/java/software/xdev/bzst/dip/client/signing/SigningProviderByJksTest.java

@@ -56,7 +56,7 @@ void getPrivateKeyWrongPassword()
 		);
 		Assertions.assertThrows(
 			SigningException.class,
-			() -> signingProviderByJks.getPrivateKey()
+			signingProviderByJks::getPrivateKey
 		);
 	}
 
@@ -69,7 +69,7 @@ void getCertificateWrongPassword()
 		);
 		Assertions.assertThrows(
 			SigningException.class,
-			() -> signingProviderByJks.getCertificate()
+			signingProviderByJks::getCertificate
 		);
 	}
 }