Skip to content

Conversation

@defalt2111
Copy link

This is the mechanism to determine the identity of the reportable ressource.

	private static ReportableSellerType.Identity createIdentity(
		final CountryCodeType resCountryCode,
		final TINType tin,
		final String in,
		final String vat,
		final String firstName,
		final String lastName,
		final AddressFixType addressFixType,
		final OECDLegalAddressTypeEnumType legalAddressTypeEnumType,
		final String birthDate,
		final String permanentEstablishments
	)
	{
		final ReportableSellerType.Identity identity = new ReportableSellerType.Identity();
		if(isNULLAsString(firstName) && isNULLAsString(birthDate)) {
                      ...
         }
	public static boolean isNULLAsString(final String checkNULLString)
	{
		return checkNULLString.equals("NULL");
	}

The old conversation from DateTime to String made it impossible for the string to be "NULL".

this.birthDate.format(DateTimeFormatter.ISO_LOCAL_DATE)

@JohannesRabauer JohannesRabauer merged commit e8206d6 into xdev-software:develop Oct 25, 2024
6 checks passed
@JohannesRabauer
Copy link
Member

Thanks @defalt2111 for that improvement!

JohannesRabauer pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants