Fix inspection problems

Author: AB-xdev

src/main/java/software/xdev/saveactions/core/component/Engine.java

@@ -1,13 +1,5 @@
 package software.xdev.saveactions.core.component;
 
-import software.xdev.saveactions.core.ExecutionMode;
-import software.xdev.saveactions.core.service.SaveActionsService;
-import software.xdev.saveactions.model.Action;
-import software.xdev.saveactions.model.Storage;
-import software.xdev.saveactions.processors.Processor;
-import software.xdev.saveactions.processors.Result;
-import software.xdev.saveactions.processors.ResultCode;
-import software.xdev.saveactions.processors.SaveCommand;
 import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.editor.Document;
 import com.intellij.openapi.fileEditor.FileDocumentManager;
@@ -17,6 +9,14 @@
 import com.intellij.psi.PsiFile;
 import com.intellij.util.PsiErrorElementUtil;
 import org.jetbrains.annotations.NotNull;
+import software.xdev.saveactions.core.ExecutionMode;
+import software.xdev.saveactions.core.service.SaveActionsService;
+import software.xdev.saveactions.model.Action;
+import software.xdev.saveactions.model.Storage;
+import software.xdev.saveactions.processors.Processor;
+import software.xdev.saveactions.processors.Result;
+import software.xdev.saveactions.processors.ResultCode;
+import software.xdev.saveactions.processors.SaveCommand;
 
 import java.util.AbstractMap.SimpleEntry;
 import java.util.List;
@@ -26,7 +26,6 @@
 import java.util.regex.Pattern;
 import java.util.regex.PatternSyntaxException;
 
-import static java.util.stream.Collectors.toList;
 import static java.util.stream.Collectors.toSet;
 
 /**
@@ -83,7 +82,7 @@ private void processPsiFiles(Project project, Set<PsiFile> psiFiles, ExecutionMo
                 .map(processor -> processor.getSaveCommand(project, psiFiles))
                 .filter(command -> storage.isEnabled(command.getAction()))
                 .filter(command -> command.getModes().contains(mode))
-                .collect(toList());
+                .toList();
         LOGGER.info(String.format("Filtered processors %s", processorsEligible));
         if (!processorsEligible.isEmpty()) {
             PsiDocumentManager psiDocumentManager = PsiDocumentManager.getInstance(project);
@@ -93,10 +92,10 @@ private void processPsiFiles(Project project, Set<PsiFile> psiFiles, ExecutionMo
                 .filter(Objects::nonNull)
                 .peek(command -> LOGGER.info(String.format("Execute command %s on %d files", command, psiFiles.size())))
                 .map(command -> new SimpleEntry<>(command.getAction(), command.execute()))
-                .collect(toList());
+                .toList();
         LOGGER.info(String.format("Exit engine with results %s", results.stream()
                 .map(entry -> entry.getKey() + ":" + entry.getValue())
-                .collect(toList())));
+                .toList()));
     }
 
     private boolean isPsiFileEligible(Project project, PsiFile psiFile) {

src/main/java/software/xdev/saveactions/core/service/SaveActionsService.java

@@ -1,11 +1,11 @@
 package software.xdev.saveactions.core.service;
 
-import software.xdev.saveactions.core.ExecutionMode;
-import software.xdev.saveactions.model.Action;
 import com.intellij.openapi.actionSystem.ex.QuickList;
 import com.intellij.openapi.components.Service;
 import com.intellij.openapi.project.Project;
 import com.intellij.psi.PsiFile;
+import software.xdev.saveactions.core.ExecutionMode;
+import software.xdev.saveactions.model.Action;
 
 import java.util.List;
 import java.util.Set;
@@ -14,7 +14,6 @@
  * This interface is implemented by all SaveAction ApplicationServices. It is used to be able to override
  * a concrete implementation. Also, it has to be annotated with {@link Service}.
  */
-@Service
 public interface SaveActionsService {
 
     void guardedProcessPsiFiles(Project project, Set<PsiFile> psiFiles, Action activation, ExecutionMode mode);

src/main/java/software/xdev/saveactions/model/ActionType.java

@@ -8,8 +8,5 @@ public enum ActionType {
 
     build,
 
-    java,
-
-    ;
-
+    java
 }

src/main/java/software/xdev/saveactions/processors/BuildProcessor.java

@@ -1,8 +1,5 @@
 package software.xdev.saveactions.processors;
 
-import software.xdev.saveactions.core.ExecutionMode;
-import software.xdev.saveactions.core.service.SaveActionsServiceManager;
-import software.xdev.saveactions.model.Action;
 import com.intellij.debugger.DebuggerManagerEx;
 import com.intellij.debugger.impl.DebuggerSession;
 import com.intellij.debugger.ui.HotSwapUI;
@@ -15,6 +12,9 @@
 import com.intellij.openapi.fileEditor.FileEditorManager;
 import com.intellij.openapi.project.Project;
 import com.intellij.psi.PsiFile;
+import software.xdev.saveactions.core.ExecutionMode;
+import software.xdev.saveactions.core.service.SaveActionsServiceManager;
+import software.xdev.saveactions.model.Action;
 
 import java.util.Arrays;
 import java.util.EnumSet;
@@ -24,11 +24,10 @@
 import java.util.function.BiFunction;
 import java.util.stream.Stream;
 
-import static software.xdev.saveactions.utils.Helper.toVirtualFiles;
 import static com.intellij.openapi.actionSystem.ActionPlaces.UNKNOWN;
 import static com.intellij.openapi.actionSystem.CommonDataKeys.EDITOR;
 import static com.intellij.openapi.actionSystem.CommonDataKeys.PROJECT;
-import static java.util.stream.Collectors.toList;
+import static software.xdev.saveactions.utils.Helper.toVirtualFiles;
 
 /**
  * Available processors for build.
@@ -61,7 +60,7 @@ public enum BuildProcessor implements Processor {
 
                 List<String> actionIds = SaveActionsServiceManager.getService().getQuickLists(project).stream()
                         .flatMap(quickList -> Arrays.stream(quickList.getActionIds()))
-                        .collect(toList());
+                        .toList();
 
                 for (String actionId : actionIds) {
                     AnAction anAction = actionManager.getAction(actionId);

src/main/java/software/xdev/saveactions/processors/java/inspection/CustomAccessCanBeTightenedInspection.java

@@ -70,9 +70,9 @@
 import java.util.concurrent.atomic.AtomicInteger;
 
 /**
- * A public version of {@link AccessCanBeTightenedInspection}.
+ * A public version of {@link com.intellij.codeInspection.visibility.AccessCanBeTightenedInspection}.
  *
- * @implNote This is a 1 to 1 copy of {@link AccessCanBeTightenedInspection}.
+ * @implNote This is a 1 to 1 copy of {@link com.intellij.codeInspection.visibility.AccessCanBeTightenedInspection}.
  * <p/>
  * Copy pasting is required because when extending the following error is thrown error:
  * <code>class com.intellij.codeInspection.visibility.CustomAccessCanBeTightenedInspection cannot access its superclass

src/main/java/software/xdev/saveactions/ui/BuildPanel.java

@@ -1,12 +1,12 @@
 package software.xdev.saveactions.ui;
 
-import software.xdev.saveactions.core.service.SaveActionsServiceManager;
-import software.xdev.saveactions.model.Action;
 import com.intellij.openapi.actionSystem.ex.QuickList;
 import com.intellij.openapi.actionSystem.ex.QuickListsManager;
 import com.intellij.openapi.ui.ComboBox;
 import com.intellij.ui.IdeBorderFactory;
 import org.jdesktop.swingx.combobox.ListComboBoxModel;
+import software.xdev.saveactions.core.service.SaveActionsServiceManager;
+import software.xdev.saveactions.model.Action;
 
 import javax.swing.Box;
 import javax.swing.BoxLayout;
@@ -23,12 +23,11 @@
 import java.util.List;
 import java.util.Map;
 
+import static java.text.MessageFormat.format;
+import static java.util.Comparator.comparing;
 import static software.xdev.saveactions.model.Action.compile;
 import static software.xdev.saveactions.model.Action.executeAction;
 import static software.xdev.saveactions.model.Action.reload;
-import static java.text.MessageFormat.format;
-import static java.util.Comparator.comparing;
-import static java.util.stream.Collectors.toList;
 
 class BuildPanel {
 
@@ -68,7 +67,7 @@ void update() {
                 .stream(QuickListsManager.getInstance().getAllQuickLists())
                 .map(QuickListWrapper::new)
                 .sorted(comparing(QuickListWrapper::toString))
-                .collect(toList());
+                .toList();
         quickListElements.clear();
         quickListElements.addAll(quickListWrappers);
         if (!quickLists.isEmpty()) {

src/main/java/software/xdev/saveactions/ui/Configuration.java

@@ -1,14 +1,14 @@
 package software.xdev.saveactions.ui;
 
+import com.intellij.openapi.options.Configurable;
+import com.intellij.openapi.project.Project;
+import org.jetbrains.annotations.Nls;
+import org.jetbrains.annotations.Nullable;
 import software.xdev.saveactions.model.Action;
 import software.xdev.saveactions.model.Storage;
 import software.xdev.saveactions.model.java.EpfStorage;
 import software.xdev.saveactions.ui.java.IdeSupportPanel;
 import software.xdev.saveactions.ui.java.InspectionPanel;
-import com.intellij.openapi.options.Configurable;
-import com.intellij.openapi.project.Project;
-import org.jetbrains.annotations.Nls;
-import org.jetbrains.annotations.Nullable;
 
 import javax.swing.Box;
 import javax.swing.BoxLayout;
@@ -260,10 +260,9 @@ private void updateCheckboxEnabledIfActiveSelected() {
     }
 
     private void updateCheckboxGroupExclusive(ActionEvent event, Action checkbox1, Action checkbox2) {
-        if (event == null || !(event.getSource() instanceof JCheckBox)) {
+        if (event == null || !(event.getSource() instanceof JCheckBox thisCheckbox)) {
             return;
         }
-        JCheckBox thisCheckbox = (JCheckBox) event.getSource();
         if (thisCheckbox.isSelected()) {
             if (thisCheckbox == checkboxes.get(checkbox1)) {
                 checkboxes.get(checkbox2).setSelected(false);

src/test/java/software/xdev/saveactions/integration/IntegrationTest.java

@@ -1,23 +1,22 @@
 package software.xdev.saveactions.integration;
 
-import software.xdev.saveactions.core.action.BatchActionConstants;
-import software.xdev.saveactions.core.action.ShortcutActionConstants;
-import software.xdev.saveactions.core.component.SaveActionManagerConstants;
-import software.xdev.saveactions.core.service.SaveActionsServiceManager;
-import software.xdev.saveactions.junit.JUnit5Utils;
-import software.xdev.saveactions.model.Storage;
 import com.intellij.testFramework.fixtures.CodeInsightTestFixture;
 import com.intellij.testFramework.fixtures.IdeaProjectTestFixture;
 import com.intellij.testFramework.fixtures.IdeaTestFixtureFactory;
 import com.intellij.testFramework.fixtures.impl.LightTempDirTestFixtureImpl;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.TestInfo;
+import software.xdev.saveactions.core.action.BatchActionConstants;
+import software.xdev.saveactions.core.action.ShortcutActionConstants;
+import software.xdev.saveactions.core.component.SaveActionManagerConstants;
+import software.xdev.saveactions.core.service.SaveActionsServiceManager;
+import software.xdev.saveactions.junit.JUnit5Utils;
+import software.xdev.saveactions.model.Storage;
 
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
-import static software.xdev.saveactions.junit.JUnit5Utils.rethrowAsJunit5Error;
 import static com.intellij.testFramework.LightProjectDescriptor.EMPTY_PROJECT_DESCRIPTOR;
 
 public abstract class IntegrationTest {

src/test/java/software/xdev/saveactions/junit/JUnit5Utils.java

@@ -12,10 +12,8 @@ private JUnit5Utils() {
     }
 
     public static void rethrowAsJunit5Error(AssertionError error) {
-        if (error.getCause() instanceof InvocationTargetException) {
-            InvocationTargetException intellijInternal = (InvocationTargetException) error.getCause();
-            if (intellijInternal.getCause() instanceof FileComparisonFailure) {
-                FileComparisonFailure fileComparisonFailure = ((FileComparisonFailure) intellijInternal.getCause());
+        if (error.getCause() instanceof InvocationTargetException intellijInternal) {
+            if (intellijInternal.getCause() instanceof FileComparisonFailure fileComparisonFailure) {
                 String expected = fileComparisonFailure.getExpected();
                 String actual = fileComparisonFailure.getActual();
                 throw new AssertionFailedError("Expected file do not match actual file", expected, actual);

src/test/java/software/xdev/saveactions/model/java/EpfKeyTest.java

@@ -5,7 +5,6 @@
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.util.List;
-import java.util.Map;
 import java.util.Properties;
 
 import static java.util.stream.Collectors.toList;
@@ -46,8 +45,7 @@ private void assertPropertyPresenceInEpf(Properties properties) {
     }
 
     private List<String> getPropertiesKeyNames(Properties properties) {
-        return properties.entrySet().stream()
-                .map(Map.Entry::getKey)
+        return properties.keySet().stream()
                 .map(Object::toString)
                 .filter(key -> EpfKey.getPrefixes().stream().anyMatch(key::startsWith))
                 .map(key -> key.substring(key.lastIndexOf(".") == -1 ? 0 : key.lastIndexOf(".") + 1))